Multithreading findScaleSpaceExtremaComputer in SIFT #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodychow
changed the title
|
@woodychow To test this PR on Buildbot with opencv/opencv#8815 you need to have the same branch name in the both PRs. |
|
Thanks. I just created a new PR to "opencv" |
|
@sovrasov, how can I trigger a rebuild? Edit: Nevermind, thanks. It had already been re-triggered. |
…rwards to make the output stable
woodychow
force-pushed
the
multithread_sift_findScaleSpaceExtrema
branch
from
1e9b679 to
6be2945
Compare
woodychow
force-pushed
the
multithread_sift_findScaleSpaceExtrema
branch
from
7e8b1a2 to
ab43a3b
Compare
|
I am not sure why the code is stalling on Mac. I don't have a dev Mac machine at the moment. |
|
👍 |
opencv-pushbot
pushed a commit
that referenced
this pull request
Sep 20, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one point about this change that I am not sure - Are stable keypoints needed? If not, the sort can be removed
I tried using thread local storage, keeping a vector of keypoints per thread and merge them at the end. It turned out that using a mutex is faster (i7 6700K). It might be slower on computers with 8 physical cores.
Needs opencv/opencv#8820