Process InputOutputArray when BM3D_STEPALL is set #1709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
certainly with my lack of experience & understanding, now should I rebuild opencv with opencv_contrib module ?? |
indr0
approved these changes
Aug 3, 2018
alalek
reviewed
Aug 3, 2018
| @@ -148,6 +148,7 @@ void bm3dDenoising( | |||
| _dst.create(srcSize, type); | |||
| break; | |||
| case BM3D_STEPALL: | |||
| _basic.create(srcSize, type); | |||
| _dst.create(srcSize, type); | |||
There was a problem hiding this comment.
Please take a look on line 159.
Perhaps this should be guarded: if (_basic.needed()) basic.create(...);
| @@ -76,7 +76,7 @@ namespace opencv_test { namespace { | |||
|
|
|||
| // BM3D: two different calls doing exactly the same thing | |||
| cv::Mat result, resultSec; | |||
| cv::xphoto::bm3dDenoising(original, cv::Mat(), resultSec, 10, 4, 16, 2500, 400, 8, 1, 0.0f, cv::NORM_L2, cv::xphoto::BM3D_STEPALL); | |||
| cv::xphoto::bm3dDenoising(original, result, resultSec, 10, 4, 16, 2500, 400, 8, 1, 0.0f, cv::NORM_L2, cv::xphoto::BM3D_STEPALL); | |||
| cv::xphoto::bm3dDenoising(original, result, 10, 4, 16, 2500, 400, 8, 1, 0.0f, cv::NORM_L2, cv::xphoto::BM3D_STEPALL); | |||
There was a problem hiding this comment.
You should not use "result" twice. It is not guaranteed that it is updated by second call.
Perhaps we should leave tests "as is" or replace Mat() to noArray().
This was referenced Aug 7, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves http://answers.opencv.org/question/196559/after-applying-cvxphotobm3ddenoising-imshow-is-giving-insertion-error/