Skip to content

Merge 3.4 #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Merge 3.4 #2013

merged 6 commits into from
Feb 26, 2019

Conversation

alalek
Copy link
Member

@alalek alalek commented Feb 26, 2019

#2007 from tedsteiner:features2d-without-highgui
#2011 from mshabunin:enable-narrowing-warning

Main PR: opencv/opencv#13920
Previous "Merge 3.4": #2006

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
docker_image:Custom=ubuntu-cuda:16.04

tedsteiner and others added 6 commits February 19, 2019 19:56
This built correctly before because tests were run with the highgui module enabled.
The sfm module links against the features2d module, which brings in the highgui module as an optional target if enabled.
Through this path, imread was working correctly despite the file including the wrong header and not declaring its linking dependency.
- Use shfl_down, instead of __shfl_down, on warp scan
- Remove race conditions

original commit: opencv/opencv@2b6be3c
@alalek
Copy link
Member Author

alalek commented Feb 26, 2019

👍

@alalek alalek merged commit 33f18dd into opencv:master Feb 26, 2019
@alalek alalek mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants