Matching operations #326
Merged
Matching operations #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions and added the calib3d module in the dependency repaired the unsuccesfull builds removed the c api removed the filterSpecleImpl This files contains the implemented descriptors The #pragma have been commented they will have to be replaced by open cv parallel for Other files will follow fixed the warnings renamed the type casting uncommented the unused macro replaced type casting with void and removed macro removed trailing white spaces removed the kernel size as class member and added it to the function header removed warning sources Rename Descriptor.cpp to descriptor.cpp renamed file Rename Descriptor.hpp to descriptor.hpp renamed hpp modified the header of header of the functions adding the Mat type for images Combined descriptors that belong in the same class together removed white spaces
reordered initiallizations removed unused variable removed tabs put const Mat:: & where needed replaced Macros with enums i did the step thing removed the white spaces from the stereo binary sgbm
removed unnecessary code modified enums and other removed class descriptor.cpp removed white spaces and fixed warnings Changed to kernel
|
@snosov1 |
| Matching::Matching(int maxDisp, int scalling, int confidence) | ||
| { | ||
| CV_Assert(maxDisp > 10); | ||
| CV_Assert(scalling != 0); |
There was a problem hiding this comment.
You have one set of checks here, and another one in functions, like setScalingFactor. As a matter of fact, the checks are slightly different, which, I assume, shouldn't be like that. Why duplicate the checks? Let's just use set* functions here.
|
@snosov1, please, let me know when/if you are fine with the content |
mirceamp
force-pushed
the
MatchingOperations
branch
from
46e7b84 to
656c4e8
Compare
fixed warnings and error replaced colls with strides fixed warnings replaced colls with strides everywhere the number of images is estabished at run time fixed braket warnings replaced all enums with a single enum removed whitespaces fixed last issues the matching class this class contains the most important functions used in stereo correspondence (StereoBM and StereoSGBM) call methods from these classes fixed shadowing warning problems included intrin.h header for popcnt instruction replaced __popcnt with _mm_popcnt_u32() equivalent fixed some warnings fixed index warning
fixed that unused variable warning fixed windows warnings Added 2 samples just to show how to access functionality fixed issues added the up to date version of sbm modified samples to be warning free
Removed the matching cpp file as it is no longer usefull removed warnings header for some used functions fixed the popcnt issue changes according to comments
removed warnings clip tab warning fixed fixed tab size warning added a new sample the new sample fixed spacing problem added a testing for the penalties fixed sample warning fixed last warnings added tests and modified a bit the sources added the tests fixed warning removed redundant samples Rename Sample3.cpp to sample.cpp renamed from Sample3 to sample refactored sample repaired descriptor test added test data usless info erased from test block matching added last tests did some modifications to the files whitespace removal did some modifications to the testing files fixed test descriptor issue Revert "whitespace removal" This reverts commit 76d4aa5. corrected part of the comments made modifications so the sources build successfully fixed some issue for sub pixel refactored sample fixed small issue at testing added some performance files performance tests and other corrections corrected the paths and added some images fixed a bug Delete imgKitty.bmp Delete imgKittyl.bmp performance tests again.... added larger images fixed issues did some last changes added the copyright notice fixed some linux errors
some extra conditions added to the sample changed scale fixed some issues regarding the matching and the sample modified expression for hamming lut condition in confidence check changed the name : bm to sgm for sample
mirceamp
force-pushed
the
MatchingOperations
branch
from
656c4e8 to
c83e49a
Compare
|
👍 |
vpisarev
added a commit
that referenced
this pull request
Nov 3, 2015
allnes
pushed a commit
to allnes/opencv_contrib
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class contains the most important functions used in stereo correspondence
(StereoBM and StereoSGBM) call methods from these classes