Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect comparison of paths for namespace resolution #104

Closed
emrainey opened this issue Jun 3, 2024 · 1 comment
Closed

Incorrect comparison of paths for namespace resolution #104

emrainey opened this issue Jun 3, 2024 · 1 comment
Assignees
@thirtytwobits
Labels
class-defect help wanted Extra attention is needed priority-high

Comments

@emrainey
Copy link

emrainey commented Jun 3, 2024

When trying to defend against /a/b/c.dsdl from colliding with /a/b/c/d.dsdl it also stops /a/b/cother/d.dsdl since it compares with a startswith and not a full basename compare in

pydsdl/pydsdl/_namespace.py

Line 270 in 98453a4

if (lu_full_namespace_period).startswith(tg_full_name_period):

@thirtytwobits thirtytwobits self-assigned this Jun 27, 2024
thirtytwobits added a commit to thirtytwobits/pydsdl that referenced this issue Jun 27, 2024
@thirtytwobits
Fix for Issue OpenCyphal#104
e4f8a6c 
This changes our logic for detecting duplicate definitions on case-sensitive file-systems to only operate on files of interest and to fix this detection logic per issue OpenCyphal#104.

If globular searches find duplicates we do not waste time detecting this until/unless these duplicates are actually considered when parsing target definitions.
@thirtytwobits thirtytwobits mentioned this issue Jun 27, 2024
Closed
thirtytwobits added a commit to thirtytwobits/pydsdl that referenced this issue Jun 28, 2024
@thirtytwobits
Fix for Issue OpenCyphal#104
5bd1f46 
This changes our logic for detecting duplicate definitions on case-sensitive file-systems to only operate on files of interest and to fix this detection logic per issue OpenCyphal#104.

If globular searches find duplicates we do not waste time detecting this until/unless these duplicates are actually considered when parsing target definitions.

# Conflicts:
#	pydsdl/_namespace.py
thirtytwobits added a commit to thirtytwobits/pydsdl that referenced this issue Jun 28, 2024
@thirtytwobits
Fix for Issue OpenCyphal#104
98cfea3 
This changes our logic for detecting duplicate definitions on case-sensitive file-systems to only operate on files of interest and to fix this detection logic per issue OpenCyphal#104.

If globular searches find duplicates we do not waste time detecting this until/unless these duplicates are actually considered when parsing target definitions.
thirtytwobits added a commit to thirtytwobits/pydsdl that referenced this issue Jun 28, 2024
@thirtytwobits
Fix for Issue OpenCyphal#104
1299df4 
This changes our logic for detecting duplicate definitions on case-sensitive file-systems to only operate on files of interest and to fix this detection logic per issue OpenCyphal#104.

If globular searches find duplicates we do not waste time detecting this until/unless these duplicates are actually considered when parsing target definitions.
@thirtytwobits thirtytwobits mentioned this issue Jun 28, 2024
Merged
thirtytwobits added a commit that referenced this issue Jul 16, 2024
@thirtytwobits @pavel-kirienko
Fix for Issue #104 (#107)
c0afc34 
This changes our logic for detecting duplicate definitions on
case-sensitive file-systems to only operate on files of interest and to
fix this detection logic per issue #104.

If globular searches find duplicates we do not waste time detecting this
until/unless these duplicates are actually considered when parsing
target definitions.

---------

Co-authored-by: Pavel Kirienko <pavel.kirienko@gmail.com>
@thirtytwobits
Copy link
Member

This fix will be available with version 1.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thirtytwobits thirtytwobits

Labels
class-defect help wanted Extra attention is needed priority-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for Issue/104 thirtytwobits/pydsdl
3 participants
@emrainey @pavel-kirienko @thirtytwobits