Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayList error in Orchestration pipeline - 4.x #756

Merged
merged 54 commits into from
Nov 12, 2021
Merged

Fix ArrayList error in Orchestration pipeline - 4.x #756

merged 54 commits into from
Nov 12, 2021

Conversation

metmajer
Copy link
Member

@metmajer metmajer commented Nov 5, 2021 •
edited by s2oBCN

  • Fix SerializationException
  • Fix NULL in SSDS generation
  • Fix SaaS bug in FinalizeStage

braisvq1996 and others added 25 commits October 29, 2021 12:17
@metmajer
Copy link
Member Author

metmajer commented Nov 5, 2021

@clemensutschig @s2oBCN I am currently not able to execute Unit tests locally. CodeNarc and Changelog need to be fixed as well.

@clemensutschig
Copy link
Member

martin - this is buggy :(

/home/runner/work/ods-jenkins-shared-library/ods-jenkins-shared-library/src/org/ods/util/Util.groovy: 33: Apparent variable 'logger' was found in a static scope but doesn't refer to a local variable, static field or class. Possible causes:
You attempted to reference a variable in the binding or an instance variable from a static context.
You misspelled a classname or statically imported field. Please check the spelling.
You attempted to use a method 'logger' but left out brackets in a place not allowed by the grammar.
@ line 33, column 17.
logger.debug ("Hit Jenkins serialization issue; attempt #: ${maxRetries - retries}")
^

1 error

@clemensutschig clemensutschig changed the title Fix ArrayList error in Orchestration pipeline Fix ArrayList error in Orchestration pipeline - 4.x Nov 9, 2021
@clemensutschig
Copy link
Member

this is incomplete - at least for the finalize stage the changes are missing ...

@clemensutschig
Copy link
Member

please also fwd port to msater :)

@s2oBCN s2oBCN merged commit 5418d47 into 4.x Nov 12, 2021
@s2oBCN s2oBCN deleted the fix/arraylist-error branch November 12, 2021 10:35
s2oBCN pushed a commit that referenced this pull request Nov 12, 2021
@metmajer @s2oBCN
Fix ArrayList error in Orchestration pipeline - 4.x (#756)
fe6e80b 
Fix SerializationException
Fix NULL in SSDS generation
Fix SaaS bug in FinalizeStage
@metmajer
Copy link
Member Author

Thanks for the fixes @s2oBCN

s2oBCN added a commit that referenced this pull request Nov 12, 2021
@s2oBCN @metmajer
Fix ArrayList error in Orchestration pipeline - 4.x (#756) (#770)
c4bf8f9 
Fix SerializationException
Fix NULL in SSDS generation
Fix SaaS bug in FinalizeStage

Co-authored-by: Martin Etmajer <martin.etmajer@boehringer-ingelheim.com>
s2oBCN pushed a commit that referenced this pull request Nov 30, 2021
@metmajer @s2oBCN
Fix ArrayList error in Orchestration pipeline - 4.x (#756)
248e610 
Fix SerializationException
Fix NULL in SSDS generation
Fix SaaS bug in FinalizeStage
s2oBCN pushed a commit that referenced this pull request Dec 1, 2021
@metmajer @s2oBCN
Fix ArrayList error in Orchestration pipeline - 4.x (#756)
389e378 
Fix SerializationException
Fix NULL in SSDS generation
Fix SaaS bug in FinalizeStage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemensutschig clemensutschig clemensutschig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.util.ArrayList$Itr error when using the orchestration pipeline
4 participants
@metmajer @clemensutschig @s2oBCN @braisvq1996