Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pruning never kicks in #557

Closed
michaelsauter opened this issue Jun 9, 2022 · 0 comments · Fixed by #558
Closed

Pruning never kicks in #557

michaelsauter opened this issue Jun 9, 2022 · 0 comments · Fixed by #558
Assignees
@michaelsauter
Labels
bug Something isn't working

Comments

@michaelsauter
Copy link
Member

Pruning should start whenever a repository is triggered. However, the channel that is used to communicate this is never written to. https://github.com/opendevstack/ods-pipeline/blob/master/cmd/pipeline-manager/main.go#L163 is the only place the channel gets passed.

The tests are missing a check for this, so it wasn't discovered :(
@michaelsauter michaelsauter added the bug Something isn't working label Jun 9, 2022
@michaelsauter michaelsauter self-assigned this Jun 9, 2022
michaelsauter added a commit that referenced this issue Jun 9, 2022
@michaelsauter
Signal when pruning should kick in
3730bb0 
Without sending on the channel, pruning will never happen.

Fixes #557.
michaelsauter added a commit that referenced this issue Jun 9, 2022
@michaelsauter
Signal when pruning should kick in
17d3509 
Without sending on the channel, pruning will never happen.

Fixes #557.
@michaelsauter michaelsauter mentioned this issue Jun 9, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelsauter michaelsauter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Signal when pruning should kick in opendevstack/ods-pipeline
1 participant
@michaelsauter