Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test skipping from build tasks #502

Merged
merged 4 commits into from
Apr 12, 2022

Conversation

henninggross
Copy link
Member

Closes #493
Closes #494
Ref #462

I searched thoroughly for any mentions of 'test skipping' and removed it. I hope that you will not find a trace of it somewhere still.

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@henninggross henninggross linked an issue Apr 7, 2022 that may be closed by this pull request
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

docs/authoring-tasks.adoc Outdated Show resolved Hide resolved
Co-authored-by: gerardcl <gerard.castillo@boehringer-ingelheim.com>
@henrjk
Copy link
Member

henrjk commented Apr 11, 2022

Let's merge this first and then adjust PR #462.

@henninggross henninggross merged commit d9750d7 into master Apr 12, 2022
@henninggross henninggross deleted the feature/494-remove-test-skipping-for-typescript branch April 12, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test skipping for Typescript Remove test skipping for Go
3 participants