Configure Git to use bearer token auth mechanism #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalyman
approved these changes
Mar 29, 2023
michaelsauter
commented
Mar 29, 2023
cmd/start/git.go
Outdated
| ) | ||
|
|
||
| // gitCheckout encapsulates the steps required to perform a Git checkout | ||
| type gitCheckout struct { |
There was a problem hiding this comment.
FYI: everything except this type and its methods is just moved from main.go.
| httpProxy string | ||
| httpsProxy string | ||
| noProxy string | ||
| url string | ||
| gitFullRef string | ||
| sslVerify string |
There was a problem hiding this comment.
FYI: When refactoring I noticed that these two params are currently unused in the checkout so I removed them.
cmd/start/main.go
Outdated
| []string{"config", | ||
| fmt.Sprintf("http.%s/info/lfs.extraHeader", opts.bitbucketURL), | ||
| fmt.Sprintf("Authorization: Bearer %s", opts.bitbucketAccessToken), | ||
| }, |
There was a problem hiding this comment.
Those two config settings are the real change here.
| Defines if http.sslVerify should be set to `true` or `false` in the global | ||
| Git config. | ||
| type: string | ||
| default: 'true' |
There was a problem hiding this comment.
As the params are not read anymore in the Go binary, we cut them here as well.
michaelsauter
force-pushed
the
fix/bitbucket-bearer-token
branch
3 times, most recently
from
1544d5f
to
96bc7e6
Compare
Tekton prepares the creds to be used through basic auth, which fails when the Bitbucket server has basic auth disabled. Fixes #683
michaelsauter
force-pushed
the
fix/bitbucket-bearer-token
branch
from
96bc7e6
to
7fe1271
Compare
oalyman
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tekton prepares the creds to be used through basic auth, which fails when the Bitbucket server has basic auth disabled.
Fixes #683
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable