This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Update from original #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: fkgozali Differential Revision: D4626085 fbshipit-source-id: f07f5a72791176f075d3ce450af4c7ae4cd6fa5c
Reviewed By: dshahidehpour Differential Revision: D4634616 fbshipit-source-id: 089eb4313c5bb810a6ff56f158cd19cec71808ec
Reviewed By: mkonicek Differential Revision: D4635182 Ninja: Manual import #12603 fbshipit-source-id: f512bf3ce7840b3fbc229e9225e06e3112d849d3
…manual API Reviewed By: davidaurelio Differential Revision: D4628593 fbshipit-source-id: 43ccdb038bd387e87096f2a7020c98d915fa5bba
Reviewed By: jeanlauliac Differential Revision: D4628330 fbshipit-source-id: 94fad1294e22fa0073e15843f94241ae778112a0
Summary:
Absolute imports on Windows were broken, I'm not 100% sure when this happens but when I tested Exponent on Windows which uses `rn-cli.config.js` with
```js
getTransformOptions() {
return {
reactNativePath: path.resolve('./node_modules/react-native'),
reactPath: path.resolve('./node_modules/react'),
};
}
```
it seemed to use absolute paths for these modules.
I also tested absolute paths in node repl and it does work for absolute paths of different formats. `C:/root/test.js`, `/root/test.js`, `C:\root\test.js` all do resolve properly to the same module.
To fix this I resolve the absolute path using `path.resolve` on Windows. Noop on other platforms to avoid the overhead since it's not necessary.
**Test plan**
- Tested that it fixed the bug I had when running Exponent on Windows.
- Updated the absolute path test to use forward slashes since this is what happens in practice when using `getTransformOptions`. We can't test all cases on linux since adding the drive letter au
Closes #12530
Differential Revision: D4634699
Pulled By: jeanlauliac
fbshipit-source-id: 0cf6528069b79cba2e0f79f48f5a524d59b7091e
Summary: I think these are sufficiently baked. Also beef up comments. Reviewed By: yungsters Differential Revision: D4632604 fbshipit-source-id: 64ae6b240a05d62e418099f7403e1781f9b4717c
Reviewed By: astreet Differential Revision: D4627339 fbshipit-source-id: eebf64e79a34331e79cffcfa3662d4938fbd6c13
Reviewed By: astreet Differential Revision: D4627219 fbshipit-source-id: 1495d58b08af3c619a8dc0d2df655e0c42aa813e
Summary: This diff adds margin:auto (https://drafts.csswg.org/css-flexbox-1/#auto-margins) support to React Native. This enables layout not previously supported without inserting empty 'spacer' views. See below Playground for usage. ``` class Playground extends React.Component { render() { return ( <View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white'}}> <View style={{width: 100, height: 100, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 'auto', backgroundColor: 'blue'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4611753 fbshipit-source-id: e78335565c193f7fb263129a638b444715ba5ab0
Summary: This diff adds alignContent (https://developer.mozilla.org/en-US/docs/Web/CSS/align-content) support to React Native. This enables aligning the lines of multi-line content. See below playground for example usage. ``` class Playground extends React.Component { render() { return ( <View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white', flexWrap: 'wrap', alignContent: 'space-between'}}> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4611803 fbshipit-source-id: ae7f6b4b7e9f4bc78d2502da948214294aad4dd2
Summary:
This diff adds display:none support to React Native. This enables hiding components which still calling their render method and keeping them within the state of your application. This enables preserving state in a component even though the component is not visible. Previously this was often implemented by rendering a component off screen as a work around. See below playground for usage.
```
class Playground extends React.Component {
render() {
return (
<View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white'}}>
<View style={{width: 100, height: 100, display: 'none', backgroundColor: 'red'}}/>
<View style={{width: 100, height: 100, backgroundColor: 'blue'}}/>
</View>
);
}
}
```
Reviewed By: astreet
Differential Revision: D4611771
fbshipit-source-id: 0dbe0494d989df42994ab9ad5125d47f3233cc5a
Summary: Move configuration to new ```YGConfig``` and pass them down to CalculateLayout. See #418 . Adds ```YGConfigNew()``` + ```YGConfigFree```, and changed ```YGSetExperimentalFeatureEnabled``` to use the config. New function for calculation is ```YGNodeCalculateLayoutWithConfig```. Closes facebook/yoga#432 Reviewed By: astreet Differential Revision: D4611359 Pulled By: emilsjolander fbshipit-source-id: a1332f0e1b21cec02129dd021ee57408449e10b0
Reviewed By: mkonicek Differential Revision: D4634272 fbshipit-source-id: 97d22115ffa29456ce253ad8c97a720d0c4e4d53
Summary: Docs change to encourage people to use React Navigation over other options. Explains a bit of history about Navigator and NavigationExperimental. Remove an intro guide that encourages use of Navigator. Hopefully the existing ReactNav guide fills this void. Navigator docs are less emphasized but still present. Reviewed By: mkonicek Differential Revision: D4634452 fbshipit-source-id: 26763c2f02530009b3dfd20b0590fadcb5ea35ee
Summary: The showcase is displayed in the homepage as well as in a standalone showcase page. The source data for these two pages is embedded in each page, resulting in repetition of data across both. This PR splits out all of the showcase data to its own file, which is then loaded into the Metadata component during website generation. `cd website && npm start`, then verified index and showcase loaded successfully `cd website && node server/generate.js`, confirmed script runs successfully Closes #12626 Differential Revision: D4632036 Pulled By: hramos fbshipit-source-id: 2d1ad890e78e457205179e36c3ef04ffec354ad9
Summary: Closes #12488 Differential Revision: D4590699 fbshipit-source-id: 003da4b622e8732ab66c6f2c931670a2eae47eae
Reviewed By: ericvicenti Differential Revision: D4636504 fbshipit-source-id: 89a776902d893c19dff81afcf1cba631c220c9c2
Summary: Also fix some bugs with fbjs requires. Reviewed By: mkonicek Differential Revision: D4635805 fbshipit-source-id: b0663b727632fe5784f1caa1ff20b160a82a3931
Reviewed By: vjeux, hramos Differential Revision: D4638610 fbshipit-source-id: 122d6fb68d521b675019a0698b6427960bb2d070
Reviewed By: cwdick Differential Revision: D4612319 fbshipit-source-id: 607a09286abdd83368996ffc553b3ce984b62f34
Summary: I am starting fresh on a new Mac and took another stab at the instructions. - Java SDK 7 seems to work just fine. - Adjusted Custom Android Studio installation instructions to use bare minimum required. - Updated AVD configuration instructions with necessary changes to run AVD the first time. - Added note on using real devices. - Removed notes warning against use of API Level 23, these do not belong on a Getting Started guide. - Added step to install Xcode Command Line Tools. - Use `.profile` over `.bashrc` as the latter is shell-specific and is not loaded on login shells (e.g. new Terminal windows). `.profile` will work on bash, however, which is the default macOS shell. - Added screenshots. Went through steps for setting up RN for iOS as well as Android on a new Mac. Ended with apps running on the iOS Simulator and a AVD. Generated website and verified instructions rendered correctly for each of the OS/device permutations. Closes #12272 Differential Revision: D4637737 Pulled By: hramos fbshipit-source-id: 5d322e4d55dbabc70f70471622a2f379ac6230cb
Reviewed By: dinhviethoa Differential Revision: D4641351 fbshipit-source-id: f965d3c55313258934d926f6333e2ba161263882
Reviewed By: hramos Differential Revision: D4638645 fbshipit-source-id: 6a37a5fd4e0d8c7769f6c241142b949dba665c34
Summary:
Set the initial opacity based on the style opacity instead of defaulting to 1. Without this change, if the opacity on the view is set to 0.5 (for example), the component will render with 1 opacity and then after a press and release it will set to 0.5. This fixes it to set to the correct value on mount.
**Test plan (required)**
Example code:
```
<TouchableOpacity
activeOpacity={1}
style={STYLES.Button}>
{...}
</TouchableOpacity>
```
```
const STYLES = StyleSheet.create({
Button: {
opacity: 0.5,
},
});
```
Before (notice starts out dark and then after click and release becomes light):
After (starts out light and is the same light color after a click and release):
Closes #12628
Differential Revision: D4641509
fbshipit-source-id: 3b6cf653fe837df704007f585c655d4450d14497
Summary: Flow improvement: Added ColorPropType on color property on Picker component Closes #12528 Differential Revision: D4619897 Pulled By: ericvicenti fbshipit-source-id: 6356d6f4ae6d2db3d93a56882ec51d140f9ac2ab
Reviewed By: kassens Differential Revision: D4636523 fbshipit-source-id: 99bbf32005073ef534c8b7d42109d9a1a1c2f945
Reviewed By: jeanlauliac Differential Revision: D4642517 fbshipit-source-id: 0882f453eb91c9f12a9e507ccfa60873106d2d71
Summary: This adds blurRadius support for <Image>, similar to iOS. The heavy-lifting was done by lambdapioneer in the stack of diffs ending with D3924013, we're just patching this in. Two notes: we might need to apply two postprocessors going forward, will tackle that in a separate diff, so we can ship this asap. However, we need a new version of fresco to be released in order to ship this. Reviewed By: lexs Differential Revision: D3936438 fbshipit-source-id: 353bf1f1120ebd5f4f8266c5a20188b41478a741
Reviewed By: davidaurelio Differential Revision: D4635348 fbshipit-source-id: 0130496e20d54f5ddf6546823b7a6cba3118917d
Reviewed By: yungsters Differential Revision: D4648383 fbshipit-source-id: fdb8e2deaa06b2d2f9002cee2c0b827dbd7a5570
Reviewed By: cpojer Differential Revision: D4681614 fbshipit-source-id: 5da558280edf300f67042e72c65b272e49351871
Reviewed By: cpojer Differential Revision: D4673384 fbshipit-source-id: 816529f8947079b4003c8e91443e221184fd589d
Summary: We use this version internally. Closes #12837 Differential Revision: D4688986 Pulled By: mkonicek fbshipit-source-id: 93d9dedb51a56d6104aae443e939455c44397e88
Summary: We use this version internally. Closes #12838 Differential Revision: D4688982 Pulled By: mkonicek fbshipit-source-id: d8a6f8168b9e71ff4f53a8c18d55dc5a759a9183
Differential Revision: D4588356 fbshipit-source-id: 88cd348ed10cbf51e8ea4cde7503f6e0f9e6c572
Summary: We have some resolve functions with ```YG**Resolve``` and others named ```YGResolve**```. This changes both to be named like the later one, as I think this is the grammatically better readable one. Closes facebook/yoga#471 Differential Revision: D4688997 Pulled By: emilsjolander fbshipit-source-id: 38b5f84d4d39ed3effedf08188085b9efd96b4ce
Summary: `onHostDestroy` is when the app is backgrounded and all Activities are destroyed. At this point it's safe to clear Fresco's memory cache. Reviewed By: AaaChiuuu Differential Revision: D4674950 fbshipit-source-id: f6db658ad56e3ad843cd2acfa31e2df1c40d3279
Summary: Not having default everywhere (keeping them at the top level instead) makes for a code that is easier to understand, and more robust as different pieces of code cannot default to different values. This changeset also unifies the option types (ex. `platform`). Reviewed By: cpojer Differential Revision: D4688882 fbshipit-source-id: b5f407601386336f937a0ac1f68c666acc89dfd8
Reviewed By: mkonicek Differential Revision: D4689351 fbshipit-source-id: 35e6939379dcb6723e7749883ad9613459f9787b
Reviewed By: AaaChiuuu Differential Revision: D4688909 fbshipit-source-id: 30d02ea6af4cce47bcd4fe41bc1f048dccbb3b2b
Reviewed By: mkonicek Differential Revision: D4689779 fbshipit-source-id: 9bc2c1447bd64ec392adef772b1189a782f83545
Summary: Closes #12866 Differential Revision: D4691348 Pulled By: ericvicenti fbshipit-source-id: df7d611aa4ed3fed6158d2210a0403c90875b7c3
Summary: Sticky headers work on android now, but are only enabled by default on ios, so reflect that in the docs. cc janicduplessis Closes #12860 Differential Revision: D4691071 fbshipit-source-id: 0e28f948dc587561b6f20c3615cdf65dfebd9b73
Summary: Minor code formatting. Each time I run `react-native init` I must reindent this file. Closes #12850 Differential Revision: D4691374 fbshipit-source-id: dc02b021e2f320f1046e4e6d024ba675a4213de8
Summary: **Motivation**: Fix Apple TV build breakage **Test plan**: This fixes Travis test that builds tvOS targets. Closes #12869 Differential Revision: D4692883 fbshipit-source-id: 3babfe4ab6d80143e15410bff7cae41ada3bf09f
…dule Reviewed By: fkgozali Differential Revision: D4688690 fbshipit-source-id: 871b3f5ab141d7f63ec15b06e44a2c398603d757
Summary: Display.getCurrentSizeRange() doesn't include the size of the status bar, so Modal windows on Android have a gap in the bottom that is the same size as the status bar. This checks the current theme and adds the size of status bar to the modal window height if necessary. **Test plan (required)** Run a React Native app on Android with a theme that doesn't show status bar and launch a modal dialog. See issue #11872 for an example. Closes #11928 Differential Revision: D4695847 fbshipit-source-id: 9fafc2b5040e2f58d562c9cc4cd4d6d87b0df2a3
Summary: The function giving the worker count was duplicated, let's just pass it down from a central place, the Bundler. Also, I simplified the function to use a simple formula rather than arbitrary ranges (it's still arbitrary, just a tad bit less :D ). Reviewed By: davidaurelio Differential Revision: D4689366 fbshipit-source-id: fe5b349396f1a07858f4f80ccaa63c375122fac8
Summary: Helps mitigate part of #12245 while we wait for a more comprehensive solution. Reviewed By: emilsjolander Differential Revision: D4571776 fbshipit-source-id: 185cd1b0d3af37724136a37471df412c2000dfe4
Summary: Also remove the unnecessary await of the resolver, because `_bundler.bundle()` already does that. Reviewed By: davidaurelio Differential Revision: D4689448 fbshipit-source-id: 3b4fd73b1368f8b00c6eb7483e751387d9856ce9
Reviewed By: yungsters Differential Revision: D4697335 fbshipit-source-id: 742b7a1729ba7a08fe3d9707bcf6c51026779739
Reviewed By: ericvicenti, gfosco Differential Revision: D4679678 fbshipit-source-id: c1088390a44540e8934666e0ffdd43a3e170de32
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see Closes #12901 Differential Revision: D4699296 Pulled By: hramos fbshipit-source-id: 514ae27c47c8ae22e1aadb99a787daa6fdc3b6a4
Reviewed By: mmmulani Differential Revision: D4672788 fbshipit-source-id: 780487f2264916349e32785808a93ed6f957e471
Summary: Closes #12868 Differential Revision: D4699900 Pulled By: hramos fbshipit-source-id: b531f2359734177df1868b453dd1d882e693caa3
…f nodes Reviewed By: mmmulani Differential Revision: D4639060 fbshipit-source-id: d4580303a61a7f86cf8bb6ec016fd9834340ffe0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.