Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-DP, posterior risk and relative risk #1816

Draft
wants to merge 3 commits into
base: 1796-fixed-approx-to-approx-dp
Choose a base branch
from

Conversation

damienbfs
Copy link
Contributor

relative risk.

@damienbfs damienbfs linked an issue Jul 18, 2024 that may be closed by this pull request
@damienbfs damienbfs self-assigned this Jul 18, 2024
Copy link
Member

Shoeboxam commented Jul 20, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @damienbfs and the rest of your teammates on Graphite Graphite

@Shoeboxam
Copy link
Member

Shoeboxam commented Jul 20, 2024

Not a full review, but while writing FFI I noticed that creating a tradeoff curve with num_approximations=0 panics. In general, try to avoid unwrapping and panicking in Rust, because it will cause the Python or R interpreter to shut down.

In cases where you want to quickly return an error, and have an error, look into the try operator in rust (?).

@Shoeboxam
Copy link
Member

Also, given that this is another form of a privacy guarantee from the library, the final result should be computed with conservative arithmetic. If you don't want this to affect compute performance of the function, you can conduct the search in standard arithmetic and then only compute the conservative version once (as done in the δ(ε) rust conversion function I sent you).

@damienbfs damienbfs force-pushed the 1796_fdp_curve branch 2 times, most recently from e8f5ae3 to 129f356 Compare July 22, 2024 16:40
@Shoeboxam Shoeboxam changed the base branch from main to 1737-approx-measure July 24, 2024 15:57
@Shoeboxam Shoeboxam force-pushed the 1737-approx-measure branch 2 times, most recently from 2a5aaf9 to b69169f Compare July 24, 2024 21:00
@Shoeboxam Shoeboxam force-pushed the 1796_fdp_curve branch 2 times, most recently from 16a0262 to 9f5b03d Compare August 6, 2024 21:14
@Shoeboxam Shoeboxam changed the base branch from 1737-approx-measure to 1796-smdcurve-conversion-ffi August 6, 2024 21:14
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from eedc842 to 3d1dbdf Compare September 5, 2024 16:31
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from 3d1dbdf to 13e3c41 Compare September 5, 2024 17:12
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from 13e3c41 to 6677e67 Compare September 5, 2024 17:39
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from 6677e67 to fc157d6 Compare September 6, 2024 01:19
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from fc157d6 to fb922b2 Compare September 6, 2024 06:22
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from fb922b2 to d6bd86d Compare September 9, 2024 22:35
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from d6bd86d to bb0e2d4 Compare September 9, 2024 22:38
@Shoeboxam Shoeboxam force-pushed the 1796-fixed-approx-to-approx-dp branch from bb0e2d4 to b76485f Compare September 9, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

β(α) curve approximation from ε(δ) curve
3 participants