-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f-DP, posterior risk and relative risk #1816
base: 1796-fixed-approx-to-approx-dp
Are you sure you want to change the base?
Conversation
f69fb19
to
7a1816c
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @damienbfs and the rest of your teammates on Graphite |
Not a full review, but while writing FFI I noticed that creating a tradeoff curve with num_approximations=0 panics. In general, try to avoid unwrapping and panicking in Rust, because it will cause the Python or R interpreter to shut down. In cases where you want to quickly return an error, and have an error, look into the try operator in rust ( |
Also, given that this is another form of a privacy guarantee from the library, the final result should be computed with conservative arithmetic. If you don't want this to affect compute performance of the function, you can conduct the search in standard arithmetic and then only compute the conservative version once (as done in the δ(ε) rust conversion function I sent you). |
e8f5ae3
to
129f356
Compare
129f356
to
cc3556f
Compare
2a5aaf9
to
b69169f
Compare
cc3556f
to
79b2926
Compare
b69169f
to
5def349
Compare
79b2926
to
afa2a17
Compare
5def349
to
b273dbb
Compare
16a0262
to
9f5b03d
Compare
d2e48e2
to
c257c1a
Compare
eedc842
to
3d1dbdf
Compare
c257c1a
to
999da01
Compare
3d1dbdf
to
13e3c41
Compare
999da01
to
c04a762
Compare
13e3c41
to
6677e67
Compare
c04a762
to
4b24863
Compare
6677e67
to
fc157d6
Compare
4b24863
to
2d3bfc5
Compare
fc157d6
to
fb922b2
Compare
2d3bfc5
to
1e67ca5
Compare
fb922b2
to
d6bd86d
Compare
1e67ca5
to
2c68cbe
Compare
d6bd86d
to
bb0e2d4
Compare
2c68cbe
to
b63dd02
Compare
bb0e2d4
to
b76485f
Compare
b63dd02
to
f9bf07d
Compare
b76485f
to
5f9b512
Compare
f9bf07d
to
fd575b5
Compare
5f9b512
to
bbbb418
Compare
fd575b5
to
6ae885a
Compare
bbbb418
to
f6586d4
Compare
6ae885a
to
f9dfce7
Compare
f6586d4
to
518909a
Compare
f9dfce7
to
bd59b7b
Compare
518909a
to
5af6060
Compare
bd59b7b
to
eba6b38
Compare
relative risk.