Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Makefile more robust #99

Closed
wants to merge 1 commit into from
Closed

Conversation

kasimon
Copy link
Contributor

@kasimon kasimon commented Jul 4, 2023

posix does not require bash to be available at /bin/bash, and some OS like NixOS do not have it there. /usr/bin/env bash is the recommended way to solve this issue and should have no negative side effects.

posix does not require bash to be available at /bin/bash, and some OS like NixOS do not have it there. ```/usr/bin/env bash``` is the recommended way to solve this issue and should have no negative side effects.
Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avishnu
Copy link
Member

avishnu commented Jul 4, 2023

This commit needs to be signed and also follow listing standards as per here.

@niladrih
Copy link
Member

niladrih commented Sep 4, 2023

Closing this PR as these changes have been included in #100.
cc: @datacore-vvarakantham

@niladrih niladrih closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants