This repository has been archived by the owner on May 6, 2024. It is now read-only.
chore: unit and component navigation #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumer92
changed the title
mumer92
force-pushed
the
umer/LEARNER-9295
branch
2 times, most recently
from
afeb6f3
to
d45a32d
Compare
mumer92
changed the title
|
@mumer92 I'm getting the following error |
saeedbashir
suggested changes
Jun 1, 2023
There was a problem hiding this comment.
- Unit title text in header shouldn't be selectable
- The header of detail screen should be the title of sub-section instead of component
- If the unit text is large the, on click the drop down menu is not appearing
- The drop down menu should be toggled if clicked multiple times
- The lock icon is different than the figma design
- The corner radius of dropdown menu is not as per figma design
- The color of bottom bar and space bellow is different, try to make it same if possible
- The space between dropdown menu and title is not as per figma
- Sometime the switching on selection from dropdown menu freezes
- If the same unit selected from the dropdown which is appearing underneeth, the clcik should should be ignored
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-01.at.12.59.06.mp4
added 5 commits
June 2, 2023 11:23
* chore: new component screen * chore: add flag for new component design
saeedbashir
suggested changes
Jun 2, 2023
mumer92
force-pushed
the
umer/LEARNER-9295
branch
from
c8dbd7b
to
17557e9
Compare
saeedbashir
suggested changes
Jun 5, 2023
There was a problem hiding this comment.
- The landscape is not supported
- On selecting a subsection, the first uncompleted unit should be opened and if all the units are completed then the last unit should be opened.
- Is it possible to merge
NewCourseGatedContentHeaderTableViewCellandNewCourseGatedContentHeaderTableViewCell? - Sometimes selecting a unit block din't update the block content
added 2 commits
June 5, 2023 17:07
saeedbashir
suggested changes
Jun 7, 2023
|
@mumer92 tests are failing can you please look into it? |
|
@saeedbashir github actions is using older version of Xcode and it is not able to compute some expression in the valid time, thus it is giving error. |
|
Followup tickets have been created to fix scrolling and landscape behaviour. https://2u-internal.atlassian.net/browse/LEARNER-9409 |
saeedbashir
pushed a commit
that referenced
this pull request
Sep 19, 2023
*chore: revert app nav changes (#1685) * chore: add indicator on tab bar (#1687) * chore: update learn tab icon (#1698) * chore: add empty state to my courses (#1697) * chore: add dashboard header view (#1705) * chore: Course Dashboard Error Screen for Non-Upgradable Courses (#1708) * chore: course tab bar flow changes in course dashboard (#1707) * chore: add error view on enrolled courses screen (#1718) * chore: course dashboard error screen for no access but upgradable courses (#1716) * chore: scrolling behaviour on course dashboard header (#1723) * feat: add new error screen for outdated version (#1725) * feat: certificate banner stylistic changes on new course dashboard (#1727) * chore: add scrolling behaviour to redesigned Learn tab (#1729) * chore: add collapsible section headers (#1726) * chore: resume course button implementation for new design #1737 (#1738) * chore: fix deeplinks with new dashboard (#1742) * fix: fix broken tests * chore: discussions deep link and push notifications support for new course dashboard (#1752) * chore: update status bar color to match course dashboard header color (#1754) * feat: show shift dates banner on new course dashboard (#1753) * feat: show shift dates banner on new course dashboard * refactor: improve value prop logic in case of embedded value prop on course dashboard fix: fix fetching of course price * fix: fix course share button on iPad (#1757) * fix: fix blank screen on fresh enrollment with app nav work (#1759) * fix: view showing behind collapsible headers (#1758) * chore: unit and component navigation (#1748) * chore: handle user interaction when user swipes quickly in page view controller (#1766) * chore: incorporate changes of course price and currency code for execute api in app_nav (#1768) * refactor: celebratory modal layout improvements (#1767) * chore: handle landscape for new dashboard and component navigation (#1769) * chore: address app nav feedback (#1772) * chore: fix title label constraint (#1775) * fix: revert of fix title label constraint (#1775)" (#1778) * fix: fix unable to dismiss an error message from course list screen (#1777) * fix: fix for subsection unwanted collapse (#1776) * fix: fix crash on new enrollment on course dashboard (#1781) * chore: expand next section after a section is marked as completed (#1782) * chore: update the edit screen title to Personal information (#1785) * chore: update shift dates banner on component screen (#1786) * chore: improve scrolling experience on discover title bar (#1788) * chore: handle header view in video block (#1798)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9295
This PR adds new unit and component navigation.
Note:
In Config, make
NEW_COMPONENT_NAVIGATION_ENABLEDandNEW_DASHBOARD_ENABLEDas true to test new navigation flow.