Management command to update voucher names and make them unique #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
suggested changes
Feb 16, 2024
There was a problem hiding this comment.
Please add a test that runs the management command twice to prove it is idempotent.
Additionally, should this be aware of the name length much like your database migration is? I think that needs to be reflected in this code, and a test should be added for that as well.
zubair-ce07
force-pushed
the
zubair-voucher-update-command
branch
from
1bd3c0e
to
d0246fa
Compare
fix: sorted imports Fix: Support create-mobile-skus to run again if failed (#4129) * fix: Support create-mobile-skus to run again if we found an error previously fix: Enable enrollment code purchase with mobile seats (#4130) * fix: Enable enrollment code purchase with mobile seats * test: Add unit test --------- Co-authored-by: Abdul Moeez Zahid <abdul.moeez@A006-01420.local> fix: PEP8 conventions fix: import issue chore: added more test cases fix: added new line at the end of file fix: blank line issue fix: long line issue fix: pylint issues fix: import issues fix: removed extra blank line fix: updated test fix: issues in command fix:: isort issue
zubair-ce07
force-pushed
the
zubair-voucher-update-command
branch
from
d0246fa
to
b405ec9
Compare
christopappas
approved these changes
Feb 20, 2024
julianajlk
approved these changes
Feb 22, 2024
| for voucher in vouchers: | ||
| assert voucher.name == f'{voucher.id} - {self.voucher_name}' | ||
|
|
||
| def test_update_voucher_names_long_name(self): |
zubair-ce07
added a commit
that referenced
this pull request
Mar 1, 2024
* chore: Added management command to update voucher names to be unique --------- Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com> Co-authored-by: Chris Pappas <cpappas@edx.org>
zubair-ce07
added a commit
that referenced
this pull request
Mar 1, 2024
* chore: Added management command to update voucher names to be unique --------- Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com> Co-authored-by: Chris Pappas <cpappas@edx.org>
zubair-ce07
added a commit
that referenced
this pull request
Mar 1, 2024
* chore: Added management command to update voucher names to be unique --------- Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com> Co-authored-by: Chris Pappas <cpappas@edx.org>
zubair-ce07
added a commit
that referenced
this pull request
Mar 1, 2024
* chore: Added management command to update voucher names to be unique --------- Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com> Co-authored-by: Chris Pappas <cpappas@edx.org>
abdullahwaheed
pushed a commit
to abdullahwaheed/ecommerce
that referenced
this pull request
Mar 1, 2024
…edx#4134) * chore: Added management command to update voucher names to be unique --------- Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com> Co-authored-by: Chris Pappas <cpappas@edx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to security@edx.org
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.
Useful information to include:
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?
Other information
Include anything else that will help reviewers and consumers understand the change.