fix: add components button in item bank children page #2491
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2491 +/- ##
=======================================
Coverage 94.67% 94.67%
=======================================
Files 1203 1203
Lines 26799 26821 +22
Branches 5874 5875 +1
=======================================
+ Hits 25372 25393 +21
- Misses 1368 1369 +1
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera !
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
Note: The iframe was not refreshed after adding an item.
| } & ( | ||
| { | ||
| componentPickerMode?: 'single', | ||
| onComponentSelected?: ComponentSelectedEvent, | ||
| onChangeComponentSelection?: never, | ||
| onComponentSelected: ComponentSelectedEvent, | ||
| onChangeComponentSelection?: ComponentSelectionChangedEvent, | ||
| } | { | ||
| componentPickerMode: 'multiple' | ||
| onComponentSelected?: never, | ||
| componentPickerMode?: 'multiple' | ||
| onComponentSelected?: ComponentSelectedEvent, | ||
| onChangeComponentSelection?: ComponentSelectionChangedEvent, | ||
| } | ||
| ); |
There was a problem hiding this comment.
This was to make the ComponentPicker type safe with the events, but if it's causing problems on the AddComponent code, we can simplify it and just add componentPickerMode, onComponentSelected and onChangeComponentSelection directly on the props type.
I think the suggestion is not getting it right, but the props can go before line 56 (} & () and we can get rid of all these props compositions.
| } & ( | |
| { | |
| componentPickerMode?: 'single', | |
| onComponentSelected?: ComponentSelectedEvent, | |
| onChangeComponentSelection?: never, | |
| onComponentSelected: ComponentSelectedEvent, | |
| onChangeComponentSelection?: ComponentSelectionChangedEvent, | |
| } | { | |
| componentPickerMode: 'multiple' | |
| onComponentSelected?: never, | |
| componentPickerMode?: 'multiple' | |
| onComponentSelected?: ComponentSelectedEvent, | |
| onChangeComponentSelection?: ComponentSelectionChangedEvent, | |
| } | |
| ); | |
| componentPickerMode?: 'single' | 'multiple', | |
| onComponentSelected?: ComponentSelectedEvent, | |
| onChangeComponentSelection?: ComponentSelectionChangedEvent, | |
| } |
There was a problem hiding this comment.
@rpenido Makes sense. Updated.
|
|
||
| export const messageTypes = { | ||
| refreshXBlock: 'refreshXBlock', | ||
| refreshIframe: 'refreshIframe', |
There was a problem hiding this comment.
Are we calling this somewhere?
After adding a component, the iframe is not refreshing on my stack.
Adding it after the sendMessageToIframe(messageTypes.addSelectedComponentsToBank, { selectedComponents }); call didn't work.
Calling sendMessageToIframe(messageTypes.refreshXBlock, null); trigger a refresh, but some times it refresh before the component is fully added because of racing conditions.
Edit: My bad. The refresh worked after I ran tutor dev exec cms npm run build-dev.
Description
The
Add componentsbutton in item bank children page was not working.Supporting information
Testing instructions
Test
Add componentsbutton in children view page of Problem/Item bank in course unit.Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'