Skip to content

Conversation

waheedahmed
Copy link
Contributor

@waheedahmed waheedahmed commented Nov 18, 2020

The LOGISTRATION_MINIMAL_HEADER environment variable removes the main menu links from the header. It also removes login/register links from the menu if user is unauthenticated.

@waheedahmed waheedahmed force-pushed the waheed/hide-header-links branch 2 times, most recently from d6fde3c to 5d2b9e4 Compare November 18, 2020 08:17
@waheedahmed waheedahmed changed the title feat: added functionality to hide header links. feat: add LOGISTRATION_MINIMAL_HEADER env variable Nov 18, 2020
@waheedahmed
Copy link
Contributor Author

waheedahmed commented Nov 18, 2020

@davidjoy Do we also need to do this in @edx/frontend-component-header-edx or the logo is configurable in this component so that we can change the logo to edX logo when we go live?

I know there is a similar env variable (MINIMAL_HEADER) available in that component as well but that does not hide the login/register links from the header and does not serve our purpose completely.

@davidjoy
Copy link
Contributor

The @edx/frontend-component-header-edx is what actually gets used on edx.org - this repository does not get used in production. I'd suggest adding this variable in that repo and leaving this one as-is.

@waheedahmed
Copy link
Contributor Author

@davidjoy I believe we need this in both to keep the user experience same for the edX and OpenedX community. I'll make a PR for @edx/frontend-component-header-edx as well.

The LOGISTRATION_MINIMAL_HEADER environment variable removes the main menu links
from the header. It also removes login/register links from the menu if user
is unauthenticated.
@waheedahmed waheedahmed force-pushed the waheed/hide-header-links branch from 5d2b9e4 to 2f2c2f7 Compare November 23, 2020 08:54
@waheedahmed
Copy link
Contributor Author

Created PR for edX specific header component as well edx/frontend-component-header-edx#105.

@waheedahmed waheedahmed merged commit 78573e3 into master Nov 23, 2020
@waheedahmed waheedahmed deleted the waheed/hide-header-links branch November 23, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants