Updated README and Deployment File #17
Conversation
- Added instructions how to deploy to Kubernetes - Example to show how a VM can be tagged based on a vCenter VM event - Connector deployment YAML updated with image supporting pending (PR Signed-off-by: Michael Gasch <embano1@live.com>
- Be more clear about `TAGURN` format - Use same example password across README Signed-off-by: Michael Gasch <embano1@live.com>
README.md
Outdated
| ```yaml | ||
| environment: | ||
| VC: vcenter.ip # must be reachable/resolvable from OpenFaaS | ||
| VCUSERNAME: VCUSER # WIP: migration to secrets |
There was a problem hiding this comment.
Should we finish the creation of secrets in your function first before merging this PR?
There was a problem hiding this comment.
I definitely would prefer that, but give the time constraints right now and people wanting to try this out, I'd point it out in the docs (so people are aware, not prod ready, etc.) and we'll fix ASAP in another commit.
There was a problem hiding this comment.
OK please can you log an issue to cover the technical debt?
README.md
Outdated
| VCPASSWORD: VCPASSWORD # WIP: migration to secrets | ||
| # Replace TAGURN example below with the one you created with govc above | ||
| TAGURN: urn:vmomi:InventoryServiceTag:019c0a9e-0672-48f5-ac2a-e394669e2916:GLOBAL | ||
| TAGACTION: attach # this function also supports detach |
There was a problem hiding this comment.
Generally we separate the words with _ like TAG_ACTION
There was a problem hiding this comment.
Also changed for VC* and will update the function examples accordingly.
|
This is amazing Michael. I've added some comments on the README that I'd like to be updated before merge. Thanks for all your effort on this Alex |
- Incorporate review feedback for README - Enable OpenFaaS auth in the deployment manifest and describe how to disable if needed Signed-off-by: Michael Gasch <embano1@live.com>
- detailed information for basic_auth enabled OpenFaaS deployment - work around the DRS powered on issue Signed-off-by: Michael Gasch <embano1@live.com>
|
Thank you @embano1 👍 this help is making a huge difference |
Signed-off-by: Michael Gasch embano1@live.com