Update Docker swarm install doc to mention ARM deployment script. #105
Conversation
Docs don't mention using the ARM script, and unfortunately if you use the non-ARM script you'll install OpenFaas in a very confusingly broken state (some nodes running, others not).
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. |
|
Sorry Derek bot, this is a simple one sentence doc change. I don't have time to jump through process hoops and machinations to get it committed. If an admin or maintainer ever sees this, feel free to update the docs with this small change so it helps the next person. Also consider reducing the friction of making simple doc updates like this in the future. |
|
Hey Tony, Thanks so much for your interest in the project. We have a contribution guide which you are asked to read as part of the PR template. Unfortunately that applies to everyone making changes even small ones. The key bit of info you needed was adding "-s" to git commit. We have 160 contributors now and that number is growing. We do need signing off of each commit. I'm sorry that this caused problems or frustration for you. I'll ask someone in the community to incorporate your suggestion in the deployment guide. On a related note there are two dedicated Raspberry Pi blog posts I wrote up in detail which explain everything you could need to know and more. I'd suggest starting there. You're also welcome to join our ARM channel in the OpenFaaS Slack community. Just let me know if you want an invite. I spent a lot of time creating this content for RPi-users. I hope it's useful for you too. https://blog.alexellis.io/your-serverless-raspberry-pi-cluster/ (Swarm) https://blog.alexellis.io/serverless-kubernetes-on-raspberry-pi/ (Kubernetes and other tutorials in the series) Alex |
|
@rgee0 is there anything we can incorporate into the deployment docs to point people at the ARM blog posts? Thanks, Alex |
|
Can we update |
|
Possibly.. it's a bit more than that maybe? What about when people are deploying to Kubernetes? We should really update both deployment guides and mention the need to use the |
|
Raised #106 for the changes. Thanks again Tony. Alex |
|
Hi, I noticed you tweeted about this contribution. Can you please remove that tweet? I don't work for Adafruit Industries. Please ask me or mention it in the contribution docs before publicizing contributions like this. I get all the discussion and such here but I'm just trying to push a small fix--not start discussion of future features, publicize contributions, etc. This is a super cool project but not everyone has time or resources to dive in and be a part of the broader community. Thanks! |
|
Hi Tony, No problem. Alex |
Docs don't mention using the ARM script, and unfortunately if you use the non-ARM script you'll install OpenFaas in a very confusingly broken state (some nodes running, others not).