Fix dead link to self-hosting page #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzr
added a commit
to TizenTeam/docs
that referenced
this pull request
Oct 1, 2019
Observed issue from page: https://docs.openfaas.com/openfaas-cloud/user-guide/ Link "OpenFaaS Cloud: Self-hosted" is broken : https://docs.openfaas.com/openfaas-cloud/ URL is showing a 404 Error So an Index page was added in self-hosting dir, and link updated accordingly. Change-Id: Ia9f2206afdd1eaa1d928f55456e80f14a2f10b9f Forwarded: openfaas#177 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
7dc1919
to
be365a4
Compare
burtonr
previously approved these changes
Oct 1, 2019
|
@rzr Please fill out the provided template by adding an |
alexellis
reviewed
Oct 1, 2019
| @@ -0,0 +1,5 @@ | |||
| # Self-hosted | |||
There was a problem hiding this comment.
Is this a new file? How does it affect existing links to these pages?
There was a problem hiding this comment.
It's a new file yes linked from other one:
see +* OpenFaaS Cloud: Self-hosted
There was a problem hiding this comment.
Please could you update the link without adding a new page? 🙏
Thank you!
rzr
commented
Oct 1, 2019
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| This guide applies to: | |||
|
|
|||
| * [OpenFaaS Cloud: Self-hosted](/openfaas-cloud/) | |||
| * [OpenFaaS Cloud: Self-hosted](/openfaas-cloud/self-hosted/) | |||
|
is anything missing ? |
Observed issue from page: https://docs.openfaas.com/openfaas-cloud/user-guide/ Link "OpenFaaS Cloud: Self-hosted" is broken : https://docs.openfaas.com/openfaas-cloud/ URL is showing a 404 Error Then an index page could be added in self-hosting dir or generated by build tool. Change-Id: Ia9f2206afdd1eaa1d928f55456e80f14a2f10b9f Forwarded: openfaas#177 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
be365a4
to
1342656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed issue from page:
https://docs.openfaas.com/openfaas-cloud/user-guide/
Link "OpenFaaS Cloud: Self-hosted" is broken :
https://docs.openfaas.com/openfaas-cloud/
URL is showing a 404 Error
So an Index page was added in self-hosting dir,
and link updated accordingly.
Change-Id: Ia9f2206afdd1eaa1d928f55456e80f14a2f10b9f
Signed-off-by: Philippe Coval p.coval@samsung.com
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
git commit -s