Change myPrivateRepo to valid secret name #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Gee <richard@technologee.co.uk>
|
Thank you Richard, good catch. |
robertgroh
added a commit
to robertgroh/docs
that referenced
this pull request
Mar 12, 2021
The Kubernetes operator `faas-netes` expects the constraints / nodeSelectors in the format <label-key>=<label-value>. References: - Pull Request ([Node selector support via constraints openfaas#77](openfaas/faas-netes#77)), which introduced the feature - the [source code for the createSelector function](https://github.com/openfaas/faas-netes/blame/master/pkg/handlers/deploy.go#L338), see how the key-value pair is split - an [issue](openfaas/faas-netes#406 (comment)) regarding the difference between constraints for Docker Swarm & Kubernetes also remove some erroneous whitespace in an URL, which broke the link and anchor
robertgroh
pushed a commit
to robertgroh/docs
that referenced
this pull request
Mar 12, 2021
The Kubernetes operator `faas-netes` expects the constraints / nodeSelectors in the format <label-key>=<label-value>. references: - pull request ([Node selector support via constraints openfaas#77](openfaas/faas-netes#77)), which introduced the feature - the [source code for the createSelector function](https://github.com/openfaas/faas-netes/blame/master/pkg/handlers/deploy.go#L338), see how the key-value pair is split - an [issue](openfaas/faas-netes#406 (comment)) regarding the difference between constraints for Docker Swarm & Kubernetes Signed-off-by: Robert Groh <robert.groh@amity.group>
robertgroh
pushed a commit
to robertgroh/docs
that referenced
this pull request
May 6, 2021
The Kubernetes operator `faas-netes` expects the constraints / nodeSelectors in the format <label-key>=<label-value>. references: - pull request ([Node selector support via constraints openfaas#77](openfaas/faas-netes#77)), which introduced the feature - the [source code for the createSelector function](https://github.com/openfaas/faas-netes/blame/master/pkg/handlers/deploy.go#L338), see how the key-value pair is split - an [issue](openfaas/faas-netes#406 (comment)) regarding the difference between constraints for Docker Swarm & Kubernetes also: - fix broken link/anchor by removing erroneous whitespace in the URL Signed-off-by: Robert Groh <robert.groh@amity.group>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76 discovered while following the link from the OFC repo docs/README.md
Signed-off-by: Richard Gee richard@technologee.co.uk