Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenFaaS Pro queue-worker to faas-netes helm chart #851

Merged
merged 2 commits into from Oct 13, 2021

Conversation

alexellis
Copy link
Member

@alexellis alexellis commented Oct 13, 2021

Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com

Description

Add OpenFaaS Pro queue-worker to faas-netes helm chart

This PR enables retries and backoff for Pro customers through an enhanced queue-worker.

See, the per-queue-worker configuration:

  maxRetryAttempts: "10"
  maxRetryWait: "120s"
  initialRetryWait: "10s"
  httpRetryCodes: "429,502,500,504,408"

To enable it, set queueWorkerPro.enabled=true with helm or arkade

Motivation and Context

The OpenFaaS Pro queue-worker is a new feature for paying customers

How Has This Been Tested?

Running kubectl logs -n openfaas deploy/queue-worker showed the new worker taking over when installed with helm, then I was able to run an async invocation against nodeinfo and see its response executing. I also confirmed that the existing queue-worker carried on workign when the pro version was disabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Enables retries and backoff for Pro customers

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis changed the title Add OpenFaaS Pro queue-worker Add OpenFaaS Pro queue-worker to faas-netes helm chart Oct 13, 2021
@alexellis alexellis merged commit 08eabd6 into master Oct 13, 2021
@alexellis alexellis deleted the add-pro-queue-worker branch October 13, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant