Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Use license-check docker image instead of curl #68

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

hasheddan
Copy link
Contributor

Description

Optimizes Docker builds by copying from license-check Docker image instead of using curl to download the tool.

Motivation and Context

  • I have raised an issue to propose this change (required)

Ref: openfaas/faas#1440

How Has This Been Tested?

make build and all containers passed license-check

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Optimizes Docker builds by copying from license-check Docker image
instead of using curl to download the tool.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit c3059c8 into openfaas:master Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants