Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-vendor queue-worker publisher for reconnect #1065

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

alexellis
Copy link
Member

Description

  • re-vendor queue-worker for publisher via 0.6.0
  • bump queue-worker version to 0.6.0 in docker-compose.yml for
    AMD64
  • use new naming for NATS of nats -> NATS in variables where
    required
  • add default reconnect of 60 times, 2 seconds apart.

Motivation and Context

  • I have raised an issue to propose this change (required)

Partial fix of: #1031

How Has This Been Tested?

Tested via PR in nats-queue-worker repo: openfaas/nats-queue-worker#49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Breaking change in type names nats -> NATS when used as prefix or in medial position for types.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- adds max_idle_conns_* default values to  docker-compose.yml to
make it easier to override as a user doing testing/tuning
- make Golang durations easier to read 300s -> 5m

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
- re-vendor queue-worker for publisher via 0.6.0
- bump queue-worker version to 0.6.0 in docker-compose.yml for
AMD64
- use new naming for NATS of nats -> NATS in variables where
required
- add default reconnect of 60 times, 2 seconds apart.

Signed-off-by: Alex Ellis (VMware) <alexellis2@gmail.com>
@alexellis alexellis merged commit b4a5503 into master Jan 29, 2019
@alexellis alexellis deleted the alexellis/bump-publisher-reconned branch January 29, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant