Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dart template #107

Closed
wants to merge 1 commit into from
Closed

Conversation

pmundt
Copy link

@pmundt pmundt commented Nov 26, 2019

Closes #94

Signed-off-by: Paul Mundt paul.mundt@adaptant.io

Signed-off-by: Paul Mundt <paul.mundt@adaptant.io>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase.

@alexellis
Copy link
Member

https://github.com/adaptant-labs/openfaas-dart-template/blob/master/template/dart/Dockerfile#L3

Please pin to a specific image tag.

https://github.com/adaptant-labs/openfaas-dart-template/blob/master/template/dart/Dockerfile#L1

Please use the latest watchdog version

https://github.com/adaptant-labs/openfaas-dart-template/blob/master/template/dart/Dockerfile#L27

Can you run pub get and pub get --offline in the same command to generate a single layer?

I would think so since you do it in Line 32

Is string/string the most appropriate type, or would you benefit from using some kind of stream or byte array?

https://github.com/adaptant-labs/openfaas-dart-template/blob/master/template/dart/function/lib/handler.dart#L1

I also wondered if dart might be better suited to the of-watchdog and using HTTP?

https://github.com/openfaas-incubator/of-watchdog#1-http-modehttp

https://github.com/adaptant-labs/openfaas-dart-template

Your readme should have some examples on how to add a dependency, I assume that's through the pubspec.yaml?

@alexellis
Copy link
Member

Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR.

@alexellis alexellis closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Dart language template
2 participants