-
Notifications
You must be signed in to change notification settings - Fork 20
release: v0.8.2 #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v0.8.2 #180
Conversation
WalkthroughThe changes update the project version from 0.8.1 to 0.8.2 across documentation, build files, configuration constants, and tests. The changelog adds a new release section documenting an internal API client accessor and a fix for the BatchCheck method. Publishing configuration now uses updated Sonatype OSSRH repository URLs. Java 24 was removed from the GitHub Actions test matrix. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to version updates, documentation, and build configuration adjustments without any new or modified control flow. Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (4)
example/example1/build.gradle (1)
25-27
: Hard-coding SDK version here invites future skewConsider reusing a single declared version (e.g. in
gradle.properties
or in the root project’sext
block) so examples stay in sync with releases:implementation "dev.openfga:openfga-sdk:${rootProject.ext.openfgaVersion}"
This keeps the sample compiling after the next bump without manual edits.
README.md (1)
80-90
: Minor Markdown style nits
markdownlint
flags mixed list markers (*
vs-
). While harmless, aligning with the chosen-
style keeps lint quiet.Example:
-* Gradle (Groovy) +- Gradle (Groovy)Apply similarly to the other package-manager lists.
Also applies to: 94-116
src/test/java/dev/openfga/sdk/api/configuration/ConfigurationTest.java (1)
24-27
: Avoid hard-coding versioned strings in testsDuplicating the
DEFAULT_USER_AGENT
literal here requires a commit every time the SDK version bumps. ImportConfiguration.DEFAULT_USER_AGENT
(or expose a constant specifically for tests) so the test auto-follows version changes.-import static org.junit.jupiter.api.Assertions.*; +import static org.junit.jupiter.api.Assertions.*; +import static dev.openfga.sdk.api.configuration.Configuration.DEFAULT_USER_AGENT; ... - private static final String DEFAULT_USER_AGENT = "openfga-sdk java/0.8.2-beta.1"; + private static final String DEFAULT_USER_AGENT = Configuration.DEFAULT_USER_AGENT;publish.gradle (1)
8-11
: Use the project’sversion
property instead of repeating the literalHard-coding the same version string in multiple Gradle files is error-prone. Reference
project.version
(already set inbuild.gradle
) so the POM always stays in sync.- version = '0.8.2-beta.1' + version = project.version
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
CHANGELOG.md
(1 hunks)README.md
(2 hunks)build.gradle
(1 hunks)example/example1/build.gradle
(1 hunks)publish.gradle
(2 hunks)src/main/java/dev/openfga/sdk/api/configuration/Configuration.java
(1 hunks)src/test/java/dev/openfga/sdk/api/configuration/ConfigurationTest.java
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Java CI with Gradle
build.gradle
[error] 1-1: Build failed: BUG! exception in phase 'semantic analysis' in source unit 'BuildScript'. Unsupported class file major version 68.
publish.gradle
[error] 54-54: Build failed: Cannot convert a null value to a File or URI. Supported types include String path, URI, File, Path, Directory, RegularFile, URI/URL, or TextResource.
🪛 markdownlint-cli2 (0.17.2)
README.md
85-85: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
101-101: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
107-107: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
113-113: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
🪛 GitHub Actions: PR #180
publish.gradle
[error] 54-54: Gradle build failed: Cannot convert a null value to a File or URI. This error occurred while evaluating the script at line 54 in publish.gradle.
🔇 Additional comments (2)
build.gradle (1)
21-23
: CI build currently fails – check toolchain / JDK pinningThe GitHub Action reported
Unsupported class file major version 68
, which means a very new JDK compiled the build-script classes while Gradle/Groovy only understands ≤ 21.
Please ensure the workflow (and local builds) run with JDK 17 – 21, e.g.- uses: actions/setup-java@v4 with: distribution: temurin java-version: '17'or configure Gradle toolchains:
java { toolchain { languageVersion = JavaLanguageVersion.of(17) } }Once the runtime is pinned, the semantic-analysis error should disappear.
CHANGELOG.md (1)
3-9
: Changelog entry looks goodRelease notes are clear and correctly linked.
src/main/java/dev/openfga/sdk/api/configuration/Configuration.java
Outdated
Show resolved
Hide resolved
dabe43f
to
4491321
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 33.65% 33.65%
Complexity 1003 1003
=========================================
Files 182 182
Lines 6890 6890
Branches 776 776
=========================================
Hits 2319 2319
Misses 4467 4467
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5fae3b9
to
df62f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
94-99
: Keep badge & docs in syncThe Maven snippet now references
0.8.2
; ensure the “Release” badge at the top of the README (line 5) and CHANGELOG both reflect the same tag so readers aren’t confused.
103-106
: Optional: deduplicate version stringsThe same version appears in five code blocks; a future bump will require editing all occurrences.
Consider using a placeholder in docs (e.g.,${openfga.version}
) or an include file during doc generation to reduce churn.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
CHANGELOG.md
(1 hunks)README.md
(2 hunks)build.gradle
(1 hunks)example/example1/build.gradle
(1 hunks)publish.gradle
(2 hunks)src/main/java/dev/openfga/sdk/api/configuration/Configuration.java
(1 hunks)src/test/java/dev/openfga/sdk/api/configuration/ConfigurationTest.java
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/main/java/dev/openfga/sdk/api/configuration/Configuration.java
🚧 Files skipped from review as they are similar to previous changes (5)
- example/example1/build.gradle
- build.gradle
- CHANGELOG.md
- src/test/java/dev/openfga/sdk/api/configuration/ConfigurationTest.java
- publish.gradle
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
85-85: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
101-101: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
107-107: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
113-113: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (3)
README.md (3)
81-89
: Confirm artifact availability on Maven CentralVersion bump looks fine, but please verify that
0.8.2
has finished propagating to Maven Central before merging; otherwise users following the README will get a 404.Optionally, you can add a note like:
> ⚠️ It may take a few minutes for a new release to appear in Maven Central.
to pre-empt installation issues.
109-112
: SBT syntax LGTMNo issues—syntactically correct and matches the new version.
115-117
: Leiningen snippet LGTMDependency string updated correctly.
Description
References
Review Checklist
main
Summary by CodeRabbit