Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renseigne l'unité de certains barèmes libellés en monnaie nominale #1020

Merged
merged 3 commits into from
Jun 29, 2018

Conversation

benjello
Copy link
Member

  • Changement mineur.
  • Détails :
    • Ajoute l'unité manquante à certains barèmes libellés en euros ou francs.

@benjello benjello requested review from guillett and sandcha and removed request for guillett June 28, 2018 09:30
@benjello
Copy link
Member Author

Related to #1019

Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionnel : des propositions de nettoyages opportunistes en commentaires.

CHANGELOG.md Outdated
@@ -14,7 +20,7 @@
* Changement mineur.
* Détails :
- Ajoute un test de performance sur les tests de CircleCI
- Ce test peut être lancé avec la commande:
- Ce test peut être lancé avec la commande:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter un espace avant les : ?

@@ -83,3 +83,4 @@ brackets:
value: 152122.0
description: 'Taxes sur les salaires : taux majorés (France métropolitaine seulement)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Déplacer description, reference et unit en haut des fichiers pour en faciliter la lecture ?

@@ -12,3 +12,4 @@ brackets:
2011-01-01:
value: 500000.0
reference: ipp
unit: currency
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En l'absence de description, je suis tombée sur cette référence (permalien) qu'on pourrait éventuellement ajouter : http://bofip.impots.gouv.fr/bofip/7804-PGP.html?identifiant=BOI-IR-CHR-20170711

@benjello benjello merged commit 8dc3d1d into master Jun 29, 2018
@benjello benjello deleted the add-taxscale-units branch June 29, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants