Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logement social in Corse #1030

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Fix logement social in Corse #1030

merged 1 commit into from
Jul 5, 2018

Conversation

guillett
Copy link
Member

@guillett guillett commented Jul 5, 2018

  • Correction d'un bug
  • Périodes concernées : à partir du 01/01/2017.
  • Zones impactées :
    • prestations/logement_social
  • Détails :
    • Corrige le calcul du logement social pour la Corse dont le code INSEE n'est pas un nombre

@guillett guillett force-pushed the fix_logement_social branch from 42ba4f8 to 33719d0 Compare July 5, 2018 14:40
@guillett guillett requested a review from monbocal July 5, 2018 14:55
@guillett guillett force-pushed the fix_logement_social branch from 33719d0 to a6426ce Compare July 5, 2018 15:00
@guillett guillett removed the request for review from monbocal July 5, 2018 15:03
@guillett guillett requested a review from fpagnoux July 5, 2018 16:32
Copy link
Member

@fpagnoux fpagnoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

Did you check there was no significant perf impact? I'm always scared when dealing with strings...

@guillett
Copy link
Member Author

guillett commented Jul 5, 2018

No I haven't, but it is not working at the moment...

@fpagnoux
Copy link
Member

fpagnoux commented Jul 5, 2018

What is not working at the moment? The test for this PR worked locally for me.

@guillett
Copy link
Member Author

guillett commented Jul 5, 2018 via email

@fpagnoux
Copy link
Member

fpagnoux commented Jul 5, 2018

Ok, I see. Anyway, you're approved to merge :)

@guillett guillett merged commit 1d7f5f7 into master Jul 5, 2018
@guillett guillett deleted the fix_logement_social branch July 5, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants