Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters #1069

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Remove unused parameters #1069

merged 2 commits into from
Aug 17, 2018

Conversation

benjello
Copy link
Member

  • Changement mineur
  • Détails :
    • Supprime des paramètres obsolètes

@benjello
Copy link
Member Author

Fixes #1068

@fpagnoux this follows #1022, so no big deal.

@benjello benjello requested a review from guillett August 14, 2018 09:02
@Anna-Livia
Copy link
Contributor

... Je crois que c'est un breaking change :/

@benjello
Copy link
Member Author

@Anna-Livia @fpagnoux : c'est mieux comme ça ?

@guillett guillett force-pushed the remove-unused-parameters branch from ce73841 to 6c339ed Compare August 17, 2018 09:21
guillett
guillett approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@guillett guillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

J'ai ajouté le nom des paramètres supprimés.

@benjello
Copy link
Member Author

Merci @guillett : je merge dès que les tests passent.

@guillett guillett merged commit 9900645 into master Aug 17, 2018
@guillett guillett deleted the remove-unused-parameters branch August 17, 2018 09:41
@benjello
Copy link
Member Author

Thanks @guillett !

@fpagnoux fpagnoux mentioned this pull request Aug 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillett guillett guillett approved these changes

@fpagnoux fpagnoux Awaiting requested review from fpagnoux

@Anna-Livia Anna-Livia Awaiting requested review from Anna-Livia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjello @Anna-Livia @guillett