Linte les fichiers YAML/Python en incrémental #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
reviewed
Sep 25, 2018
.circleci/lint-changed-yaml-tests.sh
Outdated
|
|
||
| last_tagged_commit=`git describe --tags --abbrev=0 --first-parent` # --first-parent ensures we don't follow tags not published in master through an unlikely intermediary merge commit | ||
|
|
||
| if ! changes=$(git diff-index --name-only --exit-code $last_tagged_commit -- "tests/*.yaml") |
There was a problem hiding this comment.
Je crois que cette commande va aussi identifier les fichiers supprimés. L'option --diff-filter=ACM peut être utile.
There was a problem hiding this comment.
Nice catch, j'ajoute :
--diff-filter=ACMR
pour tester aussi les changements de nom.
Morendil
reviewed
Sep 25, 2018
tests/formulas/paje/paje.yaml
Outdated
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| - name: "Avant le 1er avril 2014, le montant de base de la PAJE est proprotionnel à la BMAF" | |||
| period: 2013-01 | |||
|
|
|||
There was a problem hiding this comment.
Est-ce que les lignes en trop doivent entraîner des erreurs de yamllint ? Il semble que le test n'a pas été déclenché en tout cas sur la CI. (edit je veux dire que le test a tourné mais n'a pas fait de KO.)
There was a problem hiding this comment.
En fait non ils ne déclenchent pas des erreurs. Je vais ajouter un test.
bonjourmauko
force-pushed
the
add-flake8-increment
branch
from
5634c42 to
88acfcd
Compare
|
(rebasée) |
Morendil
approved these changes
Sep 26, 2018
bonjourmauko
force-pushed
the
add-flake8-increment
branch
from
88acfcd to
60cf399
Compare
added 3 commits
October 1, 2018 13:46
Depuis le dernier published git tag (version)
bonjourmauko
force-pushed
the
add-flake8-increment
branch
3 times, most recently
from
6cc3569 to
0dd2770
Compare
bonjourmauko
changed the title
bonjourmauko
changed the title
This was referenced Oct 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child of #372
Relates to #1039
.circleci.yamllint).flake8).Ces changements :
.circleci).Quelques conseils à prendre en compte :
Documentez votre contribution avec des références législatives.Mettez à jour ou ajoutez des tests correspondant à votre contribution.Augmentez le numéro de version danssetup.py.Mettez à jour leCHANGELOG.md.