Lint model/revenus #1139
Merged
Lint model/revenus #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonjourmauko
force-pushed
the
auto-lint-files
branch
2 times, most recently
from
653dcb3 to
884525e
Compare
Morendil
approved these changes
Oct 3, 2018
fpagnoux
changed the title
fpagnoux
changed the title
fpagnoux
reviewed
Oct 3, 2018
setup.py
Outdated
| 'flake8 == 3.4.1', | ||
| 'flake8 >= 3.5.0, < 3.6.0', | ||
| 'autopep8 >= 1.4.0, < 1.5.0', | ||
| 'pycodestyle < 2.4.0', |
There was a problem hiding this comment.
pycodestyle est déjà une dépendance de flake8, pourquoi préciser la version explicitement, alors que l'on ne l'utilise pas directement?
There was a problem hiding this comment.
Parce que si t'installes fait :
pip install pycodestyle
et après
make install
la version ne sera pas downgradée. Et flake8 est incompatible avec > 2.5.0
bonjourmauko
force-pushed
the
auto-lint-files
branch
2 times, most recently
from
afcf61d to
93422ea
Compare
bonjourmauko
changed the title
bonjourmauko
force-pushed
the
auto-lint-files
branch
from
93422ea to
a298e0c
Compare
bonjourmauko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1057
Relates to #1060
Child of #372
openfisca_france/model/revenus/**/*.Quelques conseils à prendre en compte :
Documentez votre contribution avec des références législatives.setup.py.CHANGELOG.md.