Uniformise les tests avec la nouvelle API #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is still an issue with Python 2, due to the lack of preservation of a dict order. Should probably be fixed in core. |
2 tasks
|
Mise à jour pour refléter la suppression des scénarios dans openfisca/openfisca-core#716, KO pour l'instant en raison d'une feature Edit modifications reportées sur #1227 |
Morendil
force-pushed
the
unif-tests-api
branch
from
d482f83 to
82ad673
Compare
|
Attention, il est sans doute préférable de se concerter à minima avec l'IPP
avant de les supprimer complètement. Ils sont utilisés par pas mal de
paquets en aval.
…On Sat, Dec 1, 2018, 07:28 Laurent Bossavit ***@***.*** wrote:
Mise à jour pour refléter la suppression des scénarios dans
openfisca/openfisca-core#716
<openfisca/openfisca-core#716>, KO pour
l'instant en raison d'une feature init_single_entity non testé dans Core
mais utilisée dans France.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALSWdYKJ99YSG10UixDrSX2vkMAEgXtpks5u0nXigaJpZM4Y27sy>
.
|
This was referenced Dec 3, 2018
Morendil
force-pushed
the
unif-tests-api
branch
from
1cf3704 to
699761f
Compare
bonjourmauko
reviewed
Dec 5, 2018
| @@ -53,6 +53,11 @@ class statut_marital(Variable): | |||
| definition_period = MONTH | |||
| set_input = set_input_dispatch_by_period | |||
|
|
|||
| def formula(individu, period, parameters): | |||
There was a problem hiding this comment.
@fpagnoux Je vois que les tests ne passent pas sans cette formule, or je ne suis pas certain d'avoir bien compris pourquoi.
There was a problem hiding this comment.
Enfoui dans les scénarios, il y avait un morceau de code qui faisait cette inférence
bonjourmauko
reviewed
Dec 5, 2018
.circleci/config.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| name: Install dependencies | |||
| command: | | |||
| make build | |||
| # pip install --editable git+https://github.com/openfisca/openfisca-core.git@BRANCH_NAME#egg=OpenFisca-Core # use a specific branch of OpenFisca-Core | |||
| pip install --editable git+https://github.com/openfisca/openfisca-core.git@uniformize-tests-api#egg=OpenFisca-Core # use a specific branch of OpenFisca-Core | |||
There was a problem hiding this comment.
Ne pas oublier de supprimer ça.
bonjourmauko
changed the title
fpagnoux
force-pushed
the
unif-tests-api
branch
from
699761f to
191b2f8
Compare
fpagnoux
force-pushed
the
unif-tests-api
branch
from
e899380 to
eb99b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to openfisca/openfisca-core#716