Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 warnings #1249

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Fix flake8 warnings #1249

merged 4 commits into from
Jan 7, 2019

Conversation

benjello
Copy link
Member

@benjello benjello commented Jan 4, 2019

  • Changement mineur.
  • Périodes concernées : aucunes.
  • Zones impactées : aucunes.
  • Détails :
    • Correction de style induites par l'exécution de make test

@benjello
Copy link
Member Author

benjello commented Jan 4, 2019

J'ai toujours ces erreurs

openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:29:2: W605 invalid escape sequence '\d'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:29:5: W605 invalid escape sequence '\.'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:157:19: W605 invalid escape sequence '\ '
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:157:26: W605 invalid escape sequence '\-'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:159:19: W605 invalid escape sequence '\ '
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:160:20: W605 invalid escape sequence '\-'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:160:24: W605 invalid escape sequence '\ '
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:169:10: W605 invalid escape sequence '\F'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:169:10: W605 invalid escape sequence '\ '
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:169:12: W605 invalid escape sequence '\R'
openfisca_france/scripts/parameters/baremes_ipp/xls_to_yaml_raw.py:169:14: W605 invalid escape sequence '\F'

et comme je pense que l'on n'aura plus besoin de ces fichiers je proposerai bine de les virer.
Mais je me dis qu'il vaut mieux attendre quelques temps.

@benjello benjello requested a review from a team January 4, 2019 14:48
@benjello benjello self-assigned this Jan 4, 2019
@Morendil
Copy link
Contributor

Morendil commented Jan 7, 2019

@benjello Je serais plutôt favorable à ce qu'on supprime ce script sans autre forme de procès… si on en a besoin on pourra toujours le retrouver dans l'historique :)

@benjello
Copy link
Member Author

benjello commented Jan 7, 2019

@Morendil : donc je vire tous le répertoire parameters/baremes_ipp ?

@Morendil
Copy link
Contributor

Morendil commented Jan 7, 2019

Oui ! :)

@benjello
Copy link
Member Author

benjello commented Jan 7, 2019

@Morendil : could you approve ;-)

@benjello benjello merged commit 10e0462 into master Jan 7, 2019
@benjello benjello deleted the flake8 branch January 7, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants