Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige des références et descriptions #1317

Merged
merged 2 commits into from
May 9, 2019
Merged

Corrige des références et descriptions #1317

merged 2 commits into from
May 9, 2019

Conversation

benjello
Copy link
Member

@benjello benjello commented Apr 29, 2019

  • Changement mineur.
  • Détails :
    • Retire une référence inadaptée.
    • Corrige le label d'une variable.

Ces changements (effacez les lignes ne correspondant pas à votre cas) :

  • Modifient des éléments non fonctionnels de ce dépôt (par exemple modification du README).

Quelques conseils à prendre en compte :

Et surtout, n'hésitez pas à demander de l'aide ! :)

@benjello benjello requested review from sandcha and claireleroy April 29, 2019 15:43
@@ -31,8 +31,7 @@ def calculate_net_from(salaire_de_base, individu, period):
class salaire_de_base(Variable):
value_type = float
entity = entities.Individu
label = u"Salaire brut ou traitement indiciaire brut"
reference = u"http://www.trader-finance.fr/lexique-finance/definition-lettre-S/Salaire-brut.html"
label = u"Salaire brut"
Copy link
Contributor

@sandcha sandcha Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existe-t-il une source fiable pour les notions aussi génériques que le salaire brut ? 🤔

@Morendil Morendil changed the title Remove label erros and junk Corrige des références et descriptions May 7, 2019
@Morendil
Copy link
Contributor

Morendil commented May 7, 2019

@benjello Je prends le merge

@Morendil Morendil merged commit 5fa593b into master May 9, 2019
@Morendil Morendil deleted the remove-junk branch May 9, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants