Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passage du pourcentage de la décote en paramètre #1355

Merged
merged 6 commits into from
Jul 12, 2019
Merged

Passage du pourcentage de la décote en paramètre #1355

merged 6 commits into from
Jul 12, 2019

Conversation

magemax
Copy link
Contributor

@magemax magemax commented Jul 9, 2019

  • Amélioration technique.
  • Périodes concernées : Aucune (formule équivalente)
  • Zones impactées : model\prelevements_obligatoires\impot_revenu\ir.py.
  • Détails :
    • passage du 0.75 en paramètre, pour permettre d'éventuelles réformes.

Ces changements (effacez les lignes ne correspondant pas à votre cas) :

  • Corrigent ou améliorent un calcul déjà existant.

@magemax magemax requested review from bonjourmauko and sandcha July 9, 2019 08:14
sandcha
sandcha requested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @magemax pour ces améliorations !
Quelques modifications mineures et c'est bon pour moi.

Note : Tests pré-existants exécutés via openfisca test tests/formulas/irpp.yaml -n "teste la décote"

@magemax magemax force-pushed the decote_as_a_parameter branch from ac25e40 to d546b91 Compare July 11, 2019 09:18
@magemax
Copy link
Contributor Author

magemax commented Jul 11, 2019

J'ai fait tous tes changements : 👍 * 5

@sandcha
Copy link
Contributor

sandcha commented Jul 12, 2019

Rebase en cours.

@sandcha sandcha force-pushed the decote_as_a_parameter branch from dd67eeb to 74079a8 Compare July 12, 2019 14:18
@sandcha sandcha force-pushed the decote_as_a_parameter branch from 74079a8 to d3bcd65 Compare July 12, 2019 14:39
sandcha
sandcha approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @magemax !
Merge en cours.

@sandcha sandcha merged commit a8a88e0 into master Jul 12, 2019
@sandcha sandcha deleted the decote_as_a_parameter branch July 12, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha sandcha approved these changes

@bonjourmauko bonjourmauko Awaiting requested review from bonjourmauko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magemax @sandcha