Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire le dossier Extensions #760

Merged
merged 3 commits into from
May 23, 2017
Merged

Conversation

Anna-Livia
Copy link
Contributor

@Anna-Livia Anna-Livia commented May 22, 2017

Connected to #736

  • Changement mineur.
  • Périodes concernées : toutes
  • Zones impactées :

Delete openfisca-france/openfisca_france/extensions

openfisca-france/.gitignore, line 19

openfisca_france/extensions

in openfisca-france/openfisca_france/france_taxbenefitsystem.py line 16, 17

EXTENSIONS_PATH = os.path.join(COUNTRY_DIR, 'extensions')
EXTENSIONS_DIRECTORIES = glob.glob(os.path.join(EXTENSIONS_PATH, ‘*/'))

openfisca-france/openfisca_france/france_taxbenefitsystem.py line 60

        for extension_dir in EXTENSIONS_DIRECTORIES:
            self.load_extension(extension_dir)
  • Détails :
    • Supprimer le dossier Extensions

Ces changements (effacez les lignes ne correspondant pas à votre cas) :

  • Modifient des éléments non fonctionnels de ce dépôt (par exemple modification du README).

@Anna-Livia Anna-Livia requested a review from fpagnoux May 22, 2017 12:57
@Anna-Livia Anna-Livia changed the title puts notebook back Removes Extensions file May 22, 2017
Copy link
Member

@fpagnoux fpagnoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Quelques lignes vides à supprimer
  • Manque le changelog

@@ -13,8 +13,7 @@


COUNTRY_DIR = os.path.dirname(os.path.abspath(__file__))
EXTENSIONS_PATH = os.path.join(COUNTRY_DIR, 'extensions')
EXTENSIONS_DIRECTORIES = glob.glob(os.path.join(EXTENSIONS_PATH, '*/'))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette ligne vide n'est pas nécessaire.

@@ -59,8 +58,7 @@ def __init__(self):

self.add_variables_from_directory(os.path.join(COUNTRY_DIR, 'model'))
self.cache_blacklist = conf_cache_blacklist
for extension_dir in EXTENSIONS_DIRECTORIES:
self.load_extension(extension_dir)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette ligne vide n'est pas nécessaire.

@Anna-Livia Anna-Livia force-pushed the Supprimer_dossier_Extensions#736 branch from 2574e3d to bf93900 Compare May 23, 2017 17:14
@Anna-Livia Anna-Livia requested a review from fpagnoux May 23, 2017 17:14
CHANGELOG.md Outdated

* Changement mineur
* Détails :
- Supprime le système de chargement automatique des extensions via le dossier `extensions` . Ce système a été remplacé par l'import d'OpenFisca France dans le template de l'extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce système a été remplacé par l'import d'OpenFisca France dans le template de l'extension.

->

Les extensions sont maintenant installées sous la forme de packages indépendants.

@fpagnoux fpagnoux merged commit cc43613 into master May 23, 2017
@fpagnoux fpagnoux deleted the Supprimer_dossier_Extensions#736 branch May 23, 2017 17:38
@MattiSG MattiSG changed the title Removes Extensions file Retire le dossier Extensions May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants