Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix de net a brut #786

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Fix de net a brut #786

merged 3 commits into from
Jun 26, 2017

Conversation

fpagnoux
Copy link
Member

  • Changement mineur
  • Détails
    • Répare la réforme de_net_a_brut.

Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarques mineures.

@@ -13,7 +13,7 @@ def calculate_net_from(salaire_de_base, simulation, period, requested_variable_n

# We're not wanting to calculate salaire_de_base again, but instead manually set it as an input variable
# To avoid possible conflicts, remove its function
simulation.holder_by_name['salaire_de_base'].formula.function = None
simulation.get_holder('salaire_de_base').formula.function = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La fonction étant dépréciée, la remplacer par simulation.get_variable_entity('salaire_de_base').get_holder('salaire_de_base') ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌


* Changement mineur
* Détails
- Répare la réforme `de_net_a_brut`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Préciser la version à partir de laquelle elle a été cassée ?

@fpagnoux fpagnoux force-pushed the fix-de-net-a-brut branch from 53f3fe7 to 7561281 Compare June 26, 2017 12:33
@fpagnoux fpagnoux merged commit 1a18648 into master Jun 26, 2017
@fpagnoux fpagnoux deleted the fix-de-net-a-brut branch June 26, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants