Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations formules #787

Merged
merged 7 commits into from
Jul 14, 2017
Merged

Migrations formules #787

merged 7 commits into from
Jul 14, 2017

Conversation

fpagnoux
Copy link
Member

  • Amélioration technique
  • Détails :
    • Migre les formules situés dans les fichiers suivant vers la syntaxe introduite par OpenFisca-Core 4 :
      • prelevements_obligatoires/impot_revenu/credits_impot.py
      • prelevements_obligatoires/impot_revenu/ir.py
      • prelevements_obligatoires/isf.py
      • prelevements_obligatoires/taxe_habitation.py
      • reforms/landais_piketty_saez.py

@fpagnoux fpagnoux requested a review from benjello July 10, 2017 15:02
@fpagnoux
Copy link
Member Author

Arg, @benjello j'avais oublié de te demander une review 😞 .

Si tu as un peu de temps pour regarder que ça a l'air correct, je veux bien, ce genre de changement a hélas tendance à provoquer rapidement des conflits 🙂 .

benjello
benjello reviewed Jul 11, 2017
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credits_impot relu et RAS. Je relis la suite ASAP.

benjello
benjello reviewed Jul 12, 2017
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ir.py OK

benjello
benjello reviewed Jul 12, 2017
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isf.py OK

benjello
benjello approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GTM !
Bravo @fpagnoux

@fpagnoux fpagnoux force-pushed the migrations-formules branch from 1757ccc to 46d3eb5 Compare July 14, 2017 09:11
@fpagnoux
Copy link
Member Author

🙂

@fpagnoux fpagnoux merged commit 1f3c188 into master Jul 14, 2017
@fpagnoux fpagnoux deleted the migrations-formules branch July 14, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpagnoux @benjello