Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize aide_logement as a calculable variable for primo-accédants #812

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

guillett
Copy link
Member

@guillett guillett commented Sep 4, 2017

  • Évolution du système socio-fiscal.
  • Périodes concernées : toutes.
  • Zones impactées : /prestations/aides_logement.
  • Détails :
    • Suppresion de la notification de non-calculabilité des aides au logement pour les primo-accédants.

@guillett guillett requested a review from benjello September 4, 2017 09:42
@@ -778,7 +778,7 @@ class aide_logement_non_calculable(Variable):
def formula(famille, period):
statut_occupation_logement = famille.demandeur.menage('statut_occupation_logement', period)

return (statut_occupation_logement == 1) * 1 + (statut_occupation_logement == 7) * 2
return (statut_occupation_logement == 7) * 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme aide_logement_non_calculable ne concerne plus que les locataire en foyer, il est peut-être plus approprié de modifier l'Enum pour ne garder que l'entrée locataire foyer. Et tracer les impacts sur les autres parties du code.

Copy link
Member Author

@guillett guillett Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cela génèrerait un breaking change sur OpenFisca-France. Étant donné que l'on souhaite implémenter les APLs pour les personnes en foyer prochainement (pas de date ferme pour le moment), je préfère créer un breaking change à la suppression complète de aide_logement_non_calculable.

@benjello la situation créée par la PR est-elle vraiment bloquante pour toi ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rien de bloquant @guillett. Si vous avez bien cela en tête, allez-y !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top merci !

@guillett guillett force-pushed the aide_logement_calculable branch from 6a8376c to d72fd5f Compare September 4, 2017 15:36
@guillett guillett merged commit 84a076f into master Sep 4, 2017
@guillett guillett deleted the aide_logement_calculable branch September 4, 2017 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants