Ipp 9 : Mise à jour de la réduction d'impôt PME non cotées (2014-2016) #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjello
requested changes
Feb 21, 2018
| f7cr = simulation.calculate('f7cr', period) | ||
| f7cu = simulation.calculate('f7cu', period) | ||
| f7cy = simulation.calculate('f7cy', period) | ||
| _P = simulation.parameters_at(period.start) |
| f7cy = simulation.calculate('f7cy', period) | ||
| f7dy = simulation.calculate('f7dy', period) | ||
| f7ey = simulation.calculate('f7ey', period) | ||
| _P = simulation.parameters_at(period.start) |
Anna-Livia
requested changes
Mar 6, 2018
| base_report_cappme_2011_PME = max_(0, min_(f7cm, seuil1) - base_report_cappme_2010_PME) | ||
| base_report_cappme_2012_PME = max_(0, min_(f7cn, seuil1 - base_report_cappme_2010_PME - base_report_cappme_2011_PME)) | ||
| base_report_cappme_2013_PME = max_(0, min_(f7cc, seuil1 - base_report_cappme_2010_PME - base_report_cappme_2011_PME - base_report_cappme_2012_PME )) | ||
| base_cappme_2014_PME = max_(0, min_(f7cu, seuil1 - base_report_cappme_2010_PME - base_report_cappme_2011_PME - base_report_cappme_2012_PME - base_report_cappme_2013_PME)) |
| base_report_cappme_2013_TPE = max_(0, min_(f7cr, seuil2 - base_report_cappme_2012_TPE)) | ||
| base_cappme_2014_TPE = max_(0, min_(f7cf, seuil2 - base_report_cappme_2012_TPE - base_report_cappme_2013_TPE)) | ||
|
|
||
| report_cappme_2013_plaf_general = f7cy |
There was a problem hiding this comment.
Est ce que cette équivalence ne pourrait pas être remontée en ligne 675 ?
| seuil4 = seuil3 - min_(seuil3, base_report_cappme_2010_PME + base_report_cappme_2011_PME) | ||
|
|
||
| return (report_cappme_2013_plaf_general + | ||
| min_(seuil2, base_report_cappme_2010_PME) * P.taux25 + |
There was a problem hiding this comment.
pour les parametre P.taux25 ...
Si le taux n'est pas amené à changer, il me semble qu'il vaudrait mieux écrire le taux en dur dans la formule.
S"il est amené à changer, il me semble qu'un terme plus générique serait plus approprié.
| seuil3 = seuil2 - min_(seuil2, base_report_cappme_2010_PME) | ||
| seuil4 = seuil3 - min_(seuil3, base_report_cappme_2010_PME + base_report_cappme_2011_PME) | ||
|
|
||
| return (report_cappme_2013_plaf_general + |
There was a problem hiding this comment.
Il vaut mieux mettre les opérateurs (
+) en début de ligne qu'en fin de ligne : https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator
claireleroy
force-pushed
the
ipp-update-tax-reduc-and-credit-saldom
branch
2 times, most recently
from
8b9973b to
2a1e7eb
Compare
…t-saldom Ipp 8 : Update réduction et crédit IR pour emploi à domicile
…n 2013 - f7.. variables were replaced by fh.. variables
…se of the ceiling due to f7dl only applies to tax reduction not tax credit
…e explicit + Add new variables
…ror for formula 2014
claireleroy
force-pushed
the
ipp-update-tax-reduction-cappme
branch
from
d7dbd44 to
acbf554
Compare
Anna-Livia
approved these changes
Apr 5, 2018
This was referenced Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Les modifications de cette PR sont comparées à la branche
ipp-update-tax-reduc-and-credit-saldom(#914)openfisca_france/model/prelevements_obligatoires/impot_revenu/variables_reductions_credits.pyopenfisca_france/model/prelevements_obligatoires/impot_revenu/reductions_impots.py.Ces changements :