Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate v3 #969

Merged
merged 6 commits into from
May 1, 2018
Merged

Deprecate v3 #969

merged 6 commits into from
May 1, 2018

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented Apr 12, 2018

Connected to openfisca/openfisca-core#586

  • Amélioration technique
  • Détails :
    • Adapte Core v23

@benjello
Copy link
Member

@fpagnoux : que dois-je regarder particulièrement ? Pas très sûr de bien faire le taf.

@fpagnoux
Copy link
Member Author

Il n'y a pas grand chose à voir, on supprime juste les tests de rétro-compatibilité avec l'ancienne syntaxe, plus quelques petites adaptations.

@sandcha
Copy link
Contributor

sandcha commented Apr 16, 2018

@fpagnoux Do we still need Holder's _array and _array_by_period? 🤔

@fpagnoux
Copy link
Member Author

Do we still need Holder's _array and _array_by_period? 🤔

I'd say no, did you spot a place where we are still using them ?

CHANGELOG.md Outdated

* Amélioration technique
* Détails :
- Adapte Core v23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapte à OpenFisca Core v23 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et supprime test_legacy_entities.py?

@@ -90,7 +90,7 @@ def compute_cotisation(individu, period, parameters, cotisation_type = None, bar

assiette_cotisations_sociales = individu('assiette_cotisations_sociales', period, options = [ADD])
plafond_securite_sociale = individu('plafond_securite_sociale', period, options = [ADD])
categorie_salarie = individu('categorie_salarie', period, options = [ADD])
categorie_salarie = individu('categorie_salarie', period.first_month)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A priori cela ne casse pas openfisca-survey-manager.
Faudrait voir aussi du côté de taxipp mais je pense que c'est moins probable.

@fpagnoux fpagnoux merged commit af2b4e8 into master May 1, 2018
@fpagnoux fpagnoux deleted the deprecate-v3 branch May 1, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants