-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate v3 #969
Deprecate v3 #969
Conversation
@fpagnoux : que dois-je regarder particulièrement ? Pas très sûr de bien faire le taf. |
Il n'y a pas grand chose à voir, on supprime juste les tests de rétro-compatibilité avec l'ancienne syntaxe, plus quelques petites adaptations. |
@fpagnoux Do we still need Holder's |
I'd say no, did you spot a place where we are still using them ? |
CHANGELOG.md
Outdated
|
||
* Amélioration technique | ||
* Détails : | ||
- Adapte Core v23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapte à
OpenFisca Core v23 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et supprime
test_legacy_entities.py
?
@@ -90,7 +90,7 @@ def compute_cotisation(individu, period, parameters, cotisation_type = None, bar | |||
|
|||
assiette_cotisations_sociales = individu('assiette_cotisations_sociales', period, options = [ADD]) | |||
plafond_securite_sociale = individu('plafond_securite_sociale', period, options = [ADD]) | |||
categorie_salarie = individu('categorie_salarie', period, options = [ADD]) | |||
categorie_salarie = individu('categorie_salarie', period.first_month) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A priori cela ne casse pas openfisca-survey-manager.
Faudrait voir aussi du côté de taxipp mais je pense que c'est moins probable.
Connected to openfisca/openfisca-core#586