Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a picture button problem #173

Closed
TaciteOFF opened this issue Nov 13, 2015 · 3 comments · Fixed by #6485
Closed

Adding a picture button problem #173

TaciteOFF opened this issue Nov 13, 2015 · 3 comments · Fixed by #6485

Comments

@TaciteOFF
Copy link
Contributor

When a product page is empty, clicking on the "Add a picture" button located under "Ingredients" moves us to the top of the page.

@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label May 20, 2016
@teolemon teolemon added the P3 label Jan 22, 2017
@teolemon teolemon removed the 🎯 P1 label Feb 16, 2017
@chk1
Copy link

chk1 commented Mar 19, 2019

Photo upload buttons are surrounded by <a> elements with href="#", my guess is that these are causing it. I can suppress the jump when I remove href="#" in my browser's devtools before clicking the button.

Is this the relevant code? Found two occurrences:

html += '<a href="#" class="button small expand" id="imgsearchbutton_' + id + '"><i class="fi-camera"></i> ' + Lang.upload_image

<a href="#" class="button small expand" id="imgsearchbutton_$id"><i class="fi-camera"></i> $product_image_with_barcode

@stephanegigandet
Copy link
Contributor

@chk1 Sorry that it took that long, I didn't notice your comment. You were right about the href="#" and there was also another issue for the file input button on top of it.

Fixed in #6485

@chk1
Copy link

chk1 commented Mar 15, 2022

Awesome, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants