Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename type to tagtype in taxonomy API #5953

Merged
merged 1 commit into from
Oct 8, 2021
Merged

fix: rename type to tagtype in taxonomy API #5953

merged 1 commit into from
Oct 8, 2021

Conversation

stephanegigandet
Copy link
Contributor

This is to make field names more consistent with what we are using in the backend and what has been used in libraries.

Discussion on openfoodfacts/openfoodfacts-dart#263

@stephanegigandet stephanegigandet added the API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) label Oct 8, 2021
@stephanegigandet stephanegigandet requested a review from a team as a code owner October 8, 2021 11:54
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stephanegigandet stephanegigandet merged commit d8cf36a into main Oct 8, 2021
@stephanegigandet stephanegigandet deleted the taxonomy-api branch October 8, 2021 14:56
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@gspencergoog gspencergoog Awaiting requested review from gspencergoog

Assignees
No one assigned
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel