-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Start associating packaging shapes images in the taxonomy #7688
Conversation
@aleene @stephanegigandet would like your input |
It's a great idea to add images for each packaging shape. Regarding the format of the property:
so the format should be something like: image:xx:/images/icons/packaging-shapes/citeo/brique-2.svg Regarding the content: We may not need to add all Citeo icons as entries in the taxonomy. If we do add them, then we should have an English names for them. It might be useful to have all of them at some point (e.g. to recognize them, even though my understanding is that they will go away in France). The focus at first should be on getting an image for all existing entries (or their parents, we can inherit the property), so that we can use them in the packaging edit interface and in knowledge panels etc. |
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge as-is, we can decide on the formatting, add image paths etc. after.
What