Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: script to preprocess intermarche packaging excel file #8431

Merged
merged 6 commits into from
Jun 5, 2023
Merged

chore: script to preprocess intermarche packaging excel file #8431

merged 6 commits into from
Jun 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented May 19, 2023 •
edited by teolemon
Loading

What

  • Packaging data from Les Mousquetaires / Intermarché contains multiple materials for the same packaging component (with different percents, totaling 100%).
  • We currently do not support multiple materials for a component, so this script pre-processes the Excel file in order to keep only the dominant material for each component.

Part of

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 19, 2023 09:42
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #8431 (0d80c4a) into main (2ab7fe6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8431   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         114      114           
  Lines       21314    21314           
  Branches     4776     4776           
=======================================
  Hits        10347    10347           
  Misses       9679     9679           
  Partials     1288     1288

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

alexgarel
alexgarel approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments suggestions.

Check perl is failing.

scripts/preprocess_intermarche_packaging_csv_file.pl Show resolved Hide resolved
scripts/preprocess_intermarche_packaging_csv_file.pl Show resolved Hide resolved
scripts/preprocess_intermarche_packaging_csv_file.pl Show resolved Hide resolved
stephanegigandet and others added 3 commits May 22, 2023 11:09
@stephanegigandet @alexgarel
Apply suggestions from code review
4a9e2f5 
Co-authored-by: Alex Garel <alex@garel.org>
@stephanegigandet
lint
b748081
@stephanegigandet
Intermarché
967c239
@teolemon teolemon added 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Data import labels May 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 7f96648 into main Jun 5, 2023
@alexgarel alexgarel deleted the packagings-intermarche-script branch June 5, 2023 17:46
MonalikaPatnaik pushed a commit to aadak99/openfoodfacts-server that referenced this pull request Jun 8, 2023
@stephanegigandet @alexgarel @MonalikaPatnaik
chore: script to preprocess intermarche packaging excel file (openfoo…
43ee8bb 
…dfacts#8431)


---------

Co-authored-by: Alex Garel <alex@garel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephanegigandet @codecov-commenter @alexgarel @teolemon