Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: some fixes to ingredients taxonomy #8684

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

Solved some of the errors reported by the taxonomy build of ingredients.txt

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #8684 (289f994) into main (9f151e1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8684   +/-   ##
=======================================
  Coverage   48.69%   48.69%           
=======================================
  Files         117      117           
  Lines       21799    21799           
  Branches     4859     4859           
=======================================
+ Hits        10614    10615    +1     
  Misses       9888     9888           
+ Partials     1297     1296    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet requested a review from a team as a code owner July 11, 2023 16:53
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks !

How far away are we from being able to enforce the check ?

@alexgarel alexgarel merged commit 32a5705 into main Jul 12, 2023
@alexgarel alexgarel deleted the ingredients-fix branch July 12, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants