Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 404 error for unknown tags #8937

Merged
merged 9 commits into from
Sep 5, 2023
Merged

fix: return 404 error for unknown tags #8937

merged 9 commits into from
Sep 5, 2023

Conversation

stephanegigandet
Copy link
Contributor

fixes #8935

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner September 1, 2023 15:25
alexgarel
alexgarel approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@alexgarel
Copy link
Member

you need a make lint and also some tests are broken @stephanegigandet

@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) API WRITE WRITE API to allow sending product info and image API v3 labels Sep 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023 •
edited
Loading

Codecov Report

Merging #8937 (49b93b5) into main (bda3567) will increase coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #8937      +/-   ##
==========================================
+ Coverage   46.03%   46.07%   +0.03%     
==========================================
  Files          64       64              
  Lines       19795    19800       +5     
  Branches     4791     4794       +3     
==========================================
+ Hits         9113     9123      +10     
+ Misses       9496     9493       -3     
+ Partials     1186     1184       -2
Files Changed Coverage Δ
lib/ProductOpener/Display.pm 11.26% <20.00%> (-0.01%) ⬇️
lib/ProductOpener/APITest.pm 77.04% <100.00%> (+2.86%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit f43eb3a into main Sep 5, 2023
13 checks passed
@alexgarel alexgarel deleted the unknown-tags branch September 5, 2023 15:09
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
API v3 API WRITE WRITE API to allow sending product info and image API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Display 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return 404 response for inexisting facets (not in taxonomy and no products)
3 participants
@stephanegigandet @alexgarel @codecov-commenter