fix: speed up Lang.pm initialization, save 2 seconds x 100 tests #9197
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
| = ProductOpener::I18N::split_tags(ProductOpener::I18N::read_po_files("$data_root/po/tags/")); | ||
| %tag_type_singular = %{$tag_type_singular_ref}; | ||
| %tag_type_plural = %{$tag_type_plural_ref}; | ||
| $path = "$data_root/data/Lang_tags.${server_domain}.sto"; |
There was a problem hiding this comment.
This is more cache data, could you move it to the cache folder.
| @@ -48,6 +49,7 @@ | |||
| mkdir("$data_root/data", 0755) or die("Could not create target directory $data_root/data : $!\n"); | |||
| } | |||
| store("$data_root/data/Lang.${server_domain}.sto", \%Lang); | |||
There was a problem hiding this comment.
here also it would be better to have it in a cache folder.
Let's do it once the migration is done. In fact /data was intended to be a "cache" folder in the sense that it contains things that can be recomputed. We should revisit those things globally. The built lang files are more like the built taxonomies, we could just use the same system we have for taxonomies. |
This is an attempt to speed up tests. Almost all tests load Lang.pm.
In profiling done with nytprof, this saves about 2 seconds per initialization. As we have 100 unit + integration tests, I'm hoping this should save 3 minutes when running all tests.