feat: 3765 - now using the "crop_image" package #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted files: * `crop_grid.dart` * `rotated_crop_controller.dart` * `rotated_crop_image.dart` * `rotation.dart` Impacted files: * `background_task_image.dart`: minor refactoring * `crop_page.dart`: renamed and moved; now using the `crop_image` package * `image_compute_container.dart`: renamed and moved; refactored * `image_crop_page.dart`: minor refactoring * `product_image_viewer.dart`: minor refactoring * `pubspec.lock`: wtf * `pubspec.yaml`: added `crop_image`, upgraded `image` and related packages * `uploaded_image_gallery.dart`: minor refactoring
Codecov Report
@@ Coverage Diff @@
## develop #3926 +/- ##
===========================================
+ Coverage 10.62% 10.96% +0.33%
===========================================
Files 268 264 -4
Lines 13506 13093 -413
===========================================
Hits 1435 1435
+ Misses 12071 11658 -413
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted files: * `background_task_image.dart`: minor refactoring * `image_compute_container.dart`: removed code that is now in `CropController` * `pubspec.lock`: wtf * `pubspec.yaml`: upgraded `crop_image`
M123-dev
approved these changes
May 1, 2023
|
Thank you @M123-dev for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
crop_imagepackage instead of (old) copies of its code.The next step will be to haveWe're all set now.crop_imagemake a method public (cf. feat: public "getCroppedBitmap" method deakjahn/crop_image#25)Part of
Files
Deleted files:
crop_grid.dartrotated_crop_controller.dartrotated_crop_image.dartrotation.dartImpacted files:
background_task_image.dart: minor refactoringcrop_page.dart: renamed and moved; now using thecrop_imagepackageimage_compute_container.dart: renamed and moved; refactoredimage_crop_page.dart: minor refactoringproduct_image_viewer.dart: minor refactoringpubspec.lock: wtfpubspec.yaml: addedcrop_image, upgradedimageand related packagesuploaded_image_gallery.dart: minor refactoring