Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3765 - now using the "crop_image" package #3926

Merged
merged 2 commits into from
May 2, 2023

Conversation

monsieurtanuki
Copy link
Contributor

@monsieurtanuki monsieurtanuki commented May 1, 2023

What

Part of

Files

Deleted files:

  • crop_grid.dart
  • rotated_crop_controller.dart
  • rotated_crop_image.dart
  • rotation.dart

Impacted files:

  • background_task_image.dart: minor refactoring
  • crop_page.dart: renamed and moved; now using the crop_image package
  • image_compute_container.dart: renamed and moved; refactored
  • image_crop_page.dart: minor refactoring
  • product_image_viewer.dart: minor refactoring
  • pubspec.lock: wtf
  • pubspec.yaml: added crop_image, upgraded image and related packages
  • uploaded_image_gallery.dart: minor refactoring

Deleted files:
* `crop_grid.dart`
* `rotated_crop_controller.dart`
* `rotated_crop_image.dart`
* `rotation.dart`

Impacted files:
* `background_task_image.dart`: minor refactoring
* `crop_page.dart`: renamed and moved; now using the `crop_image` package
* `image_compute_container.dart`: renamed and moved; refactored
* `image_crop_page.dart`: minor refactoring
* `product_image_viewer.dart`: minor refactoring
* `pubspec.lock`: wtf
* `pubspec.yaml`: added `crop_image`, upgraded `image` and related packages
* `uploaded_image_gallery.dart`: minor refactoring
@codecov-commenter
Copy link

Codecov Report

Merging #3926 (48a43ed) into develop (a8366fd) will increase coverage by 0.33%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3926      +/-   ##
===========================================
+ Coverage    10.62%   10.96%   +0.33%     
===========================================
  Files          268      264       -4     
  Lines        13506    13093     -413     
===========================================
  Hits          1435     1435              
+ Misses       12071    11658     -413     
Impacted Files Coverage Δ
...ooth_app/lib/background/background_task_image.dart 0.00% <0.00%> (ø)
...mooth_app/lib/helpers/image_compute_container.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/pages/crop_page.dart 0.00% <0.00%> (ø)
...th_app/lib/pages/image/uploaded_image_gallery.dart 0.00% <ø> (ø)
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% <ø> (ø)
...th_app/lib/pages/product/product_image_viewer.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Impacted files:
* `background_task_image.dart`: minor refactoring
* `image_compute_container.dart`: removed code that is now in `CropController`
* `pubspec.lock`: wtf
* `pubspec.yaml`: upgraded `crop_image`
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼 thanks @monsieurtanuki

@monsieurtanuki monsieurtanuki merged commit 2115b8b into openfoodfacts:develop May 2, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants