Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deep-link capture for Signup (https://world.openfoodfacts.org/cgi/user.pl) #4169

Closed
Tracked by #4016
teolemon opened this issue Jun 15, 2023 · 2 comments · Fixed by #5332
Closed
Tracked by #4016

Add deep-link capture for Signup (https://world.openfoodfacts.org/cgi/user.pl) #4169

teolemon opened this issue Jun 15, 2023 · 2 comments · Fixed by #5332
Assignees
@jnnabugwu
Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps good first issue Good for newcomers P3 👥 User management Account login, signup, signout

Comments

@teolemon
Copy link
Member

teolemon commented Jun 15, 2023 •
edited
Loading

What

Code pointers

You can find some code pointers here. If some are missing, feel free to add them yourself in this file, or to ask them.

Part of
@teolemon teolemon mentioned this issue Jun 15, 2023
Open
@teolemon teolemon added good first issue Good for newcomers 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps 👥 User management Account login, signup, signout labels Jun 15, 2023
@teolemon teolemon added the P3 label Feb 15, 2024
@jnnabugwu
Copy link
Contributor

I'd love to work on this.

@g123k
Copy link
Collaborator

g123k commented May 23, 2024 •
edited
Loading

Here is are some details:

  • Even if the onboarding is not OK, we force the Signup screen
  • At the end of the signup, if the boarding is not passed, we show it

jnnabugwu added a commit to jnnabugwu/smooth-app that referenced this issue Jun 2, 2024
@jnnabugwu
feat: added sign up deeplink openfoodfacts#4169
c0e6ab1
jnnabugwu added a commit to jnnabugwu/smooth-app that referenced this issue Jun 2, 2024
@jnnabugwu
feat: added deeplinking for the sign up page openfoodfacts#4169
da71ec5 
### What
<!-- Added deep linking for the sign up page-->
- <!-- Changed x to achieve y -->
<!--
Please name your pull request following this scheme: `type: What you did` this allows us to automatically generate the changelog
Following `type`s are allowed:
  - `feat`, for Features
  - `fix`, for Bug Fixes
  - `docs`, for Documentation
  - `ci`, for Automation
  - `refactor`, for code Refactoring
  - `chore`, for Miscellaneous things
-->
### Screenshot
<!-- Insert a screenshot to provide visual record of your changes, if visible -->

### Fixes bug(s)
<!-- change by appropriate issues. -->
<!-- Please use a linking keyword https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword -->
- Fixes: <!-- openfoodfacts#1 Note: you can also use Closes: -->

### Part of
- openfoodfacts#525 <!-- Add the most granular issue possible -->
@g123k g123k linked a pull request Jun 7, 2024 that will close this issue
feat: added deeplinking for the sign up page #4169 #5332
Merged
teolemon pushed a commit that referenced this issue Jun 7, 2024
@jnnabugwu
feat: added deeplinking for the sign up page #4169 (#5332)
2e44edb 
* feat: added sign up deeplink #4169

* feat: made it so that the user goes to onboarding after sign up

* feat: added deeplinking for the sign up page #4169
### What
<!-- Added deep linking for the sign up page-->
- <!-- Changed x to achieve y -->
<!--
Please name your pull request following this scheme: `type: What you did` this allows us to automatically generate the changelog
Following `type`s are allowed:
  - `feat`, for Features
  - `fix`, for Bug Fixes
  - `docs`, for Documentation
  - `ci`, for Automation
  - `refactor`, for code Refactoring
  - `chore`, for Miscellaneous things
-->
### Screenshot
<!-- Insert a screenshot to provide visual record of your changes, if visible -->

### Fixes bug(s)
<!-- change by appropriate issues. -->
<!-- Please use a linking keyword https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword -->
- Fixes: <!-- #1 Note: you can also use Closes: -->

### Part of
- #525 <!-- Add the most granular issue possible -->

* feat: added an external link for the signup page

* feat: moved the getting of user preferences to the success state only
@github-actions github-actions bot mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnnabugwu jnnabugwu

Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps good first issue Good for newcomers P3 👥 User management Account login, signup, signout
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added deeplinking for the sign up page #4169 jnnabugwu/smooth-app
3 participants
@g123k @teolemon @jnnabugwu