Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sign in with email no longer have unwanted consquences #3499

Merged
merged 2 commits into from
Jan 2, 2023
Merged

fix: Sign in with email no longer have unwanted consquences #3499

merged 2 commits into from
Jan 2, 2023

Conversation

AshAman999
Copy link
Member

What

  • Save the userId instead of the user's email
  • Is the userId always returned if the login is successful ?
  • comments to add ?

Screenshot

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner January 2, 2023 17:57
monsieurtanuki
monsieurtanuki approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @AshAman999!

@M123-dev M123-dev merged commit b60ce32 into openfoodfacts:develop Jan 2, 2023
@M123-dev
Copy link
Member

M123-dev commented Jan 2, 2023

Thanks @AshAman999

@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Merged
@monsieurtanuki monsieurtanuki mentioned this pull request Mar 15, 2024
Closed
@teolemon teolemon added the 👥 User management Account login, signup, signout label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees

@AshAman999 AshAman999

Labels
👥 User management Account login, signup, signout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't access my profile on web from Your profile menu
4 participants
@AshAman999 @M123-dev @monsieurtanuki @teolemon